Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2281)

Unified Diff: appengine/findit/waterfall/start_try_job_on_demand_pipeline.py

Issue 2026283002: [Findit] Adding logic to force try jobs regardless of bailout or previous results (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: Addressing comments and rebase Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/waterfall/start_try_job_on_demand_pipeline.py
diff --git a/appengine/findit/waterfall/start_try_job_on_demand_pipeline.py b/appengine/findit/waterfall/start_try_job_on_demand_pipeline.py
index d6c6c4952eaaa79621c39130c1c7743cfaceb133..750000a2d4c06372fae8462ef683b30b9ed60160 100644
--- a/appengine/findit/waterfall/start_try_job_on_demand_pipeline.py
+++ b/appengine/findit/waterfall/start_try_job_on_demand_pipeline.py
@@ -3,7 +3,6 @@
# found in the LICENSE file.
from common.pipeline_wrapper import BasePipeline
-from common.waterfall import failure_type
from model.wf_analysis import WfAnalysis
from waterfall import try_job_util
@@ -11,13 +10,15 @@ from waterfall import try_job_util
class StartTryJobOnDemandPipeline(BasePipeline):
# Arguments number differs from overridden method - pylint: disable=W0221
- def run(self, failure_info, signals, build_completed, heuristic_result):
+ def run(self, failure_info, signals, build_completed, force_try_job,
+ heuristic_result):
"""Starts a try job if one is needed for the given failure."""
if not build_completed: # Only start try-jobs for completed builds.
return False
failure_result_map = try_job_util.ScheduleTryJobIfNeeded(
- failure_info, signals=signals, heuristic_result=heuristic_result)
+ failure_info, signals=signals, heuristic_result=heuristic_result,
+ force_try_job=force_try_job)
# Save reference to the try-jobs if any was scheduled.
master_name = failure_info['master_name']

Powered by Google App Engine
This is Rietveld 408576698