[css3-text] Implement text-decoration property shorthand

Source/core/css/CSSComputedStyleDeclaration.cpp

Index: Source/core/css/CSSComputedStyleDeclaration.cpp
diff --git a/Source/core/css/CSSComputedStyleDeclaration.cpp b/Source/core/css/CSSComputedStyleDeclaration.cpp
index 6fdc5a27e8a8d8aefd43e57b1169c926f1d73537..f2a2ed56cfd5c6b9577170a195e50d9874198287 100644
--- a/Source/core/css/CSSComputedStyleDeclaration.cpp
+++ b/Source/core/css/CSSComputedStyleDeclaration.cpp
@@ -2179,6 +2179,7 @@ PassRefPtr<CSSValue> CSSComputedStyleDeclaration::getPropertyCSSValue(CSSPropert
         case CSSPropertyTextAlignLast:
             return cssValuePool().createValue(style->textAlignLast());
         case CSSPropertyTextDecoration:
+            return getTextDecorationShorthandValue();
         case CSSPropertyTextDecorationLine:
             return renderTextDecorationFlagsToCSSValue(style->textDecoration());
         case CSSPropertyTextDecorationStyle:
@@ -3083,4 +3084,13 @@ PassRefPtr<CSSValueList> CSSComputedStyleDeclaration::getBackgroundShorthandValu
     return list.release();
 }
 
+PassRefPtr<CSSValueList> CSSComputedStyleDeclaration::getTextDecorationShorthandValue() const
+{
+    static const CSSPropertyID properties[3] = { CSSPropertyTextDecorationLine, CSSPropertyTextDecorationStyle, CSSPropertyTextDecorationColor };
+
+    RefPtr<CSSValueList> list = CSSValueList::createSpaceSeparated();
+    list->append(getCSSPropertyValuesForShorthandProperties(StylePropertyShorthand(CSSPropertyTextDecoration, properties, WTF_ARRAY_LENGTH(properties))));

[Julien - ping for review, 2013/07/29 18:53:12]

CSSComputedStyleDeclaration::getCSSPropertyValuesForShorthandProperties already
returns a space-separated list of properties. Couldn't we just return
getCSSPropertyValuesForShorthandProperties(textDecorationShorthand()) above
instead of wrapping this list in another list?

[abinader, 2013/07/29 21:15:32]

Nice catch, Julien! By using
getCSSPropertyValuesForShorthandProperties(textDecorationShorthand()) I was able
to catch a typo in CSSShorthands.in, where the longhand property orders for
text-decoration were incorrect (causing the computed style layout test to fail).

+    return list.release();
+}
+
 } // namespace WebCore