[css3-text] Implement text-decoration property shorthand

Source/core/css/CSSComputedStyleDeclaration.cpp

 /*
  * Copyright (C) 2004 Zack Rusin <zack@kde.org>
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved.
  * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org>
  * Copyright (C) 2007 Nicholas Shanks <webkit@nickshanks.com>
  * Copyright (C) 2011 Sencha, Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
  * License as published by the Free Software Foundation; either
@@ skipping 2161 matching lines @@
             return getPositionOffsetValue(style.get(), CSSPropertyRight, renderer, m_node->document()->renderView());
         case CSSPropertyWebkitRubyPosition:
             return cssValuePool().createValue(style->rubyPosition());
         case CSSPropertyTableLayout:
             return cssValuePool().createValue(style->tableLayout());
         case CSSPropertyTextAlign:
             return cssValuePool().createValue(style->textAlign());
         case CSSPropertyTextAlignLast:
             return cssValuePool().createValue(style->textAlignLast());
         case CSSPropertyTextDecoration:
+            return getTextDecorationShorthandValue();
         case CSSPropertyTextDecorationLine:
             return renderTextDecorationFlagsToCSSValue(style->textDecoration());
         case CSSPropertyTextDecorationStyle:
             return renderTextDecorationStyleFlagsToCSSValue(style->textDecorationStyle());
         case CSSPropertyTextDecorationColor:
             return currentColorOrValidColor(style.get(), style->textDecorationColor());
 #if ENABLE(CSS3_TEXT)
         case CSSPropertyWebkitTextUnderlinePosition:
             return cssValuePool().createValue(style->textUnderlinePosition());
 #endif // CSS3_TEXT
@@ skipping 884 matching lines @@
                                                                      CSSPropertyBackgroundPosition };
     static const CSSPropertyID propertiesAfterSlashSeperator[3] = { CSSPropertyBackgroundSize, CSSPropertyBackgroundOrigin,
                                                                     CSSPropertyBackgroundClip };
 
     RefPtr<CSSValueList> list = CSSValueList::createSlashSeparated();
     list->append(getCSSPropertyValuesForShorthandProperties(StylePropertyShorthand(CSSPropertyBackground, propertiesBeforeSlashSeperator, WTF_ARRAY_LENGTH(propertiesBeforeSlashSeperator))));
     list->append(getCSSPropertyValuesForShorthandProperties(StylePropertyShorthand(CSSPropertyBackground, propertiesAfterSlashSeperator, WTF_ARRAY_LENGTH(propertiesAfterSlashSeperator))));
     return list.release();
 }
 
+PassRefPtr<CSSValueList> CSSComputedStyleDeclaration::getTextDecorationShorthandValue() const
+{
+    static const CSSPropertyID properties[3] = { CSSPropertyTextDecorationLine, CSSPropertyTextDecorationStyle, CSSPropertyTextDecorationColor };
+
+    RefPtr<CSSValueList> list = CSSValueList::createSpaceSeparated();
+    list->append(getCSSPropertyValuesForShorthandProperties(StylePropertyShorthand(CSSPropertyTextDecoration, properties, WTF_ARRAY_LENGTH(properties))));

[Julien - ping for review, 2013/07/29 18:53:12]

CSSComputedStyleDeclaration::getCSSPropertyValuesForShorthandProperties already
returns a space-separated list of properties. Couldn't we just return
getCSSPropertyValuesForShorthandProperties(textDecorationShorthand()) above
instead of wrapping this list in another list?

[abinader, 2013/07/29 21:15:32]

Nice catch, Julien! By using
getCSSPropertyValuesForShorthandProperties(textDecorationShorthand()) I was able
to catch a typo in CSSShorthands.in, where the longhand property orders for
text-decoration were incorrect (causing the computed style layout test to fail).

+    return list.release();
+}
+
 } // namespace WebCore