Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issue 2026113002: [libfuzzer] use source-built expat parser (Closed)

Created:
4 years, 6 months ago by aizatsky
Modified:
4 years, 6 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[libfuzzer] use source-built expat parser Fuzzer can't progress with system one, you need to instrument sources. BUG= Committed: https://crrev.com/8f4bcd2f2244dcde5beb4627e3e9842445948e5b Cr-Commit-Position: refs/heads/master@{#397277}

Patch Set 1 #

Total comments: 2

Patch Set 2 : comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M third_party/expat/BUILD.gn View 1 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
aizatsky
4 years, 6 months ago (2016-05-31 22:53:43 UTC) #2
mmoroz
LGTM Now it makes sense why that fuzzer is so boring! Thanks Mike!
4 years, 6 months ago (2016-06-01 11:58:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2026113002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2026113002/1
4 years, 6 months ago (2016-06-01 11:58:50 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/192815)
4 years, 6 months ago (2016-06-01 12:04:37 UTC) #7
Nico
lgtm with comment addressed https://codereview.chromium.org/2026113002/diff/1/third_party/expat/BUILD.gn File third_party/expat/BUILD.gn (right): https://codereview.chromium.org/2026113002/diff/1/third_party/expat/BUILD.gn#newcode8 third_party/expat/BUILD.gn:8: # Chromecast doesn't ship expat ...
4 years, 6 months ago (2016-06-01 15:44:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2026113002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2026113002/20001
4 years, 6 months ago (2016-06-01 20:54:45 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-01 23:08:00 UTC) #12
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/8f4bcd2f2244dcde5beb4627e3e9842445948e5b Cr-Commit-Position: refs/heads/master@{#397277}
4 years, 6 months ago (2016-06-01 23:09:36 UTC) #14
aizatsky
4 years, 6 months ago (2016-06-02 21:02:08 UTC) #15
Message was sent while issue was closed.
https://codereview.chromium.org/2026113002/diff/1/third_party/expat/BUILD.gn
File third_party/expat/BUILD.gn (right):

https://codereview.chromium.org/2026113002/diff/1/third_party/expat/BUILD.gn#...
third_party/expat/BUILD.gn:8: # Chromecast doesn't ship expat as a system
library
On 2016/06/01 at 15:44:14, Nico wrote:
> can you add the comment
> 
>       # On Linux, we implicitly already depend on expat via fontconfig;
>       # let's not pull it in twice.
> 
> from the gyp file?

Done. Also added libfuzzer comment.

Powered by Google App Engine
This is Rietveld 408576698