Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(496)

Unified Diff: third_party/expat/BUILD.gn

Issue 2026113002: [libfuzzer] use source-built expat parser (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comments Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/expat/BUILD.gn
diff --git a/third_party/expat/BUILD.gn b/third_party/expat/BUILD.gn
index e70f31be067f4c0562daa86f364b1048e843d29f..642cd7ac2ddf2783cd724cbc0f0253e8847d735d 100644
--- a/third_party/expat/BUILD.gn
+++ b/third_party/expat/BUILD.gn
@@ -5,8 +5,11 @@
import("//build/config/chromecast_build.gni")
import("//testing/libfuzzer/fuzzer_test.gni")
-# Chromecast doesn't ship expat as a system library
-if (is_linux && !is_chromecast) {
+# On Linux, we implicitly already depend on expat via fontconfig;
+# let's not pull it in twice.
+# Chromecast doesn't ship expat as a system library.
+# Libfuzzer needs to build library from sources.
+if (is_linux && !is_chromecast && !use_libfuzzer) {
config("expat_config") {
libs = [ "expat" ]
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698