Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Issue 2026103002: Remove wtf::String::characterAt. (Closed)

Created:
4 years, 6 months ago by esprehn
Modified:
4 years, 6 months ago
Reviewers:
haraken, ojan
CC:
blink-reviews, blink-reviews-wtf_chromium.org, chromium-reviews, Mikhail
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove wtf::String::characterAt. This was done for some vague compiler reason in webkit, but is not really used by Blink and there's no do mention in the original bug https://bugs.webkit.org/show_bug.cgi?id=95509 Lets just remove it. Committed: https://crrev.com/2a8b2c535b9ccd16ca05747b6df3a33a049bab11 Cr-Commit-Position: refs/heads/master@{#396992}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -9 lines) Patch
M third_party/WebKit/Source/core/editing/GranularityStrategyTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/text/WTFString.h View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2026103002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2026103002/1
4 years, 6 months ago (2016-05-31 22:43:32 UTC) #2
esprehn
4 years, 6 months ago (2016-05-31 23:18:23 UTC) #4
haraken
LGTM
4 years, 6 months ago (2016-05-31 23:29:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2026103002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2026103002/1
4 years, 6 months ago (2016-05-31 23:34:28 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-01 00:32:03 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-01 00:35:02 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2a8b2c535b9ccd16ca05747b6df3a33a049bab11
Cr-Commit-Position: refs/heads/master@{#396992}

Powered by Google App Engine
This is Rietveld 408576698