Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(960)

Side by Side Diff: third_party/WebKit/Source/wtf/text/WTFString.h

Issue 2026103002: Remove wtf::String::characterAt. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/core/editing/GranularityStrategyTest.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * (C) 1999 Lars Knoll (knoll@kde.org) 2 * (C) 1999 Lars Knoll (knoll@kde.org)
3 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012, 2013 Apple Inc. All rights reserved. 3 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012, 2013 Apple Inc. All rights reserved.
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
(...skipping 430 matching lines...) Expand 10 before | Expand all | Expand 10 after
441 441
442 // Hash table deleted values, which are only constructed and never copied or 442 // Hash table deleted values, which are only constructed and never copied or
443 // destroyed. 443 // destroyed.
444 String(WTF::HashTableDeletedValueType) : m_impl(WTF::HashTableDeletedValue) { } 444 String(WTF::HashTableDeletedValueType) : m_impl(WTF::HashTableDeletedValue) { }
445 bool isHashTableDeletedValue() const { return m_impl.isHashTableDeletedValue (); } 445 bool isHashTableDeletedValue() const { return m_impl.isHashTableDeletedValue (); }
446 446
447 #ifndef NDEBUG 447 #ifndef NDEBUG
448 void show() const; 448 void show() const;
449 #endif 449 #endif
450 450
451 // Workaround for a compiler bug. Use operator[] instead.
452 UChar characterAt(unsigned index) const
453 {
454 if (!m_impl || index >= m_impl->length())
455 return 0;
456 return (*m_impl)[index];
457 }
458
459 private: 451 private:
460 typedef struct ImplicitConversionFromWTFStringToBoolDisallowed* (String::*Un specifiedBoolType); 452 typedef struct ImplicitConversionFromWTFStringToBoolDisallowed* (String::*Un specifiedBoolType);
461 operator UnspecifiedBoolType() const; 453 operator UnspecifiedBoolType() const;
462 454
463 template <typename CharacterType> 455 template <typename CharacterType>
464 void removeInternal(const CharacterType*, unsigned, int); 456 void removeInternal(const CharacterType*, unsigned, int);
465 457
466 template <typename CharacterType> 458 template <typename CharacterType>
467 void appendInternal(CharacterType); 459 void appendInternal(CharacterType);
468 460
(...skipping 236 matching lines...) Expand 10 before | Expand all | Expand 10 after
705 using WTF::charactersToFloat; 697 using WTF::charactersToFloat;
706 using WTF::equal; 698 using WTF::equal;
707 using WTF::equalIgnoringCase; 699 using WTF::equalIgnoringCase;
708 using WTF::find; 700 using WTF::find;
709 using WTF::isAllSpecialCharacters; 701 using WTF::isAllSpecialCharacters;
710 using WTF::isSpaceOrNewline; 702 using WTF::isSpaceOrNewline;
711 using WTF::reverseFind; 703 using WTF::reverseFind;
712 704
713 #include "wtf/text/AtomicString.h" 705 #include "wtf/text/AtomicString.h"
714 #endif // WTFString_h 706 #endif // WTFString_h
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/editing/GranularityStrategyTest.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698