Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2026003002: Fix an issue that filename is missing in download failure notification (Closed)

Created:
4 years, 6 months ago by qinmin
Modified:
4 years, 6 months ago
Reviewers:
michaelbai
CC:
chromium-reviews, asanka
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

Fix an issue that filename is missing in download failure notification When resuming a download, it is possible that the download is not in history db. In this case, native code won't be able to provide the filename. We need to get the file name from sharedpreferences TBR=michaelbai@chromium.org BUG=614867 Review-Url: https://codereview.chromium.org/2007983007 Cr-Commit-Position: refs/heads/master@{#396321} (cherry picked from commit c916d5295b2c636581db6271c242e35bf7394411) Review URL: https://codereview.chromium.org/2019793002 . Cr-Commit-Position: refs/branch-heads/2704@{#668} Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251} (cherry picked from commit 51af006325a102d9a29830fe98dff32ed02824b4) Committed: https://chromium.googlesource.com/chromium/src/+/66befcc7574b14a10bda95137669f02274d44e4a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java View 2 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
qinmin
4 years, 6 months ago (2016-05-31 19:00:49 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
66befcc7574b14a10bda95137669f02274d44e4a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698