Fix an issue that filename is missing in download failure notification

Fix an issue that filename is missing in download failure notification

When resuming a download, it is possible that the download is not in
history db.
In this case, native code won't be able to provide the filename.
We need to get the file name from sharedpreferences

BUG=614867
Committed: https://crrev.com/c916d5295b2c636581db6271c242e35bf7394411
Cr-Commit-Position: refs/heads/master@{#396321}

[qinmin, 2016-05-25 23:47:55]

qinmin@chromium.org changed reviewers:
+ tedchoc@chromium.org

[qinmin, 2016-05-25 23:47:56]

PTAL

[qinmin, 2016-05-26 18:32:09]

qinmin@chromium.org changed reviewers:
+ michaelbai@chromium.org
- tedchoc@chromium.org

[qinmin, 2016-05-26 18:32:09]

+michaelbai as Ted is OOO

[michaelbai, 2016-05-26 18:34:31]

rubber stamp LGTM

[qinmin, 2016-05-26 18:50:29]

The CQ bit was checked by qinmin@chromium.org

[commit-bot: I haz the power, 2016-05-26 18:50:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2007983007/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2007983007/1

[qinmin, 2016-05-26 18:53:03]

The CQ bit was unchecked by qinmin@chromium.org

[qinmin, 2016-05-26 18:58:27]

Patchset #1 (id:1) has been deleted

[qinmin, 2016-05-26 18:58:32]

The CQ bit was checked by qinmin@chromium.org

[qinmin, 2016-05-26 18:58:32]

The patchset sent to the CQ was uploaded after l-g-t-m from
michaelbai@chromium.org
Link to the patchset: https://codereview.chromium.org/2007983007/#ps20001
(title: " ")

[commit-bot: I haz the power, 2016-05-26 18:58:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2007983007/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2007983007/20001

[commit-bot: I haz the power, 2016-05-26 20:15:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-26 20:15:17]

Failed to apply patch for
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java:
While running git apply --index -3 -p1;
  error: patch failed:
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java:15
  Falling back to three-way merge...
  Applied patch to
'chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java'
with conflicts.
  U
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java

Patch:      
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java
Index:
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java
diff --git
a/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java
b/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java
index
6650be754492f4e727a3611fb3330abf78a109ae..17aa535f1f8d2d9ca28a178f359f80a9fa6ae393
100644
---
a/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java
+++
b/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java
@@ -15,6 +15,7 @@ import android.content.SharedPreferences;
 import android.os.Binder;
 import android.os.IBinder;
 import android.support.v4.app.NotificationCompat;
+import android.text.TextUtils;
 
 import org.chromium.base.ContextUtils;
 import org.chromium.base.Log;
@@ -235,6 +236,14 @@ public class DownloadNotificationService extends Service {
      * @param fileName GUID of the download.
      */
     public void notifyDownloadFailed(int notificationId, String downloadGuid,
String fileName) {
+        // If the download is not in history db, fileName could be empty. Get
it from
+        // SharedPreferences.
+        if (TextUtils.isEmpty(fileName)) {
+            DownloadSharedPreferenceEntry entry =
getDownloadSharedPreferenceEntry(downloadGuid);
+            if (entry == null) return;
+            fileName = entry.fileName;
+        }
+
         NotificationCompat.Builder builder = buildNotification(
                 android.R.drawable.stat_sys_download_done, fileName,
                
mContext.getResources().getString(R.string.download_notification_failed));

[commit-bot: I haz the power, 2016-05-26 20:15:30]

The CQ bit was unchecked by commit-bot@chromium.org

[qinmin, 2016-05-26 22:15:35]

The CQ bit was checked by qinmin@chromium.org

[qinmin, 2016-05-26 22:15:36]

The patchset sent to the CQ was uploaded after l-g-t-m from
michaelbai@chromium.org
Link to the patchset: https://codereview.chromium.org/2007983007/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2016-05-26 22:16:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2007983007/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2007983007/40001

[commit-bot: I haz the power, 2016-05-26 23:46:36]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-05-26 23:48:02]

Description was changed from

==========
Fix an issue that filename is missing in download failure notification

When resuming a download, it is possible that the download is not in
history db.
In this case, native code won't be able to provide the filename.
We need to get the file name from sharedpreferences

BUG=614867
==========

to

==========
Fix an issue that filename is missing in download failure notification

When resuming a download, it is possible that the download is not in
history db.
In this case, native code won't be able to provide the filename.
We need to get the file name from sharedpreferences

BUG=614867

Committed: https://crrev.com/c916d5295b2c636581db6271c242e35bf7394411
Cr-Commit-Position: refs/heads/master@{#396321}
==========

[commit-bot: I haz the power, 2016-05-26 23:48:03]

Patchset 2 (id:??) landed as
https://crrev.com/c916d5295b2c636581db6271c242e35bf7394411
Cr-Commit-Position: refs/heads/master@{#396321}