Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2025973002:
Re-enable WebGL Image Chromium. (Closed)
|
Created:
4 years, 6 months ago by erikchen Modified:
4 years, 6 months ago CC:
chromium-reviews, krit, pdr+graphicswatchlist_chromium.org, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, f(malita), jam, jbroman, Justin Novosad, Rik, darin-cc_chromium.org, dshwang, blink-reviews, piman+watch_chromium.org, Stephen Chennney, ajuma+watch_chromium.org, danakj+watch_chromium.org, rwlbuis Base URL:
https://chromium.googlesource.com/chromium/src.git@temp64_webgl_deschedule Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRe-enable WebGL Image Chromium.
This CL makes DrawingBuffer use the newly added DescheduleUntilFinishedCHROMIUM,
and turns on IOSurface backed WebGL by default.
BUG=581777
Committed: https://crrev.com/801f15833c140f120a2f5baed88645cb0619ab86
Cr-Commit-Position: refs/heads/master@{#397603}
Patch Set 1 #Patch Set 2 : #Patch Set 3 : #
Dependent Patchsets: Messages
Total messages: 35 (16 generated)
The CQ bit was checked by erikchen@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2025973002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2025973002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...) mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
The CQ bit was checked by erikchen@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2025973002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2025973002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Re-enable WebGL Image Chromium. BUG= ========== to ========== Re-enable WebGL Image Chromium. This CL makes DrawingBuffer use the newly added DescheduleUntilFinishedCHROMIUM, and also turns on IOSurface backed WebGL by default. BUG= ==========
Description was changed from ========== Re-enable WebGL Image Chromium. This CL makes DrawingBuffer use the newly added DescheduleUntilFinishedCHROMIUM, and also turns on IOSurface backed WebGL by default. BUG= ========== to ========== Re-enable WebGL Image Chromium. This CL makes DrawingBuffer use the newly added DescheduleUntilFinishedCHROMIUM, and turns on IOSurface backed WebGL by default. BUG=581777 ==========
erikchen@chromium.org changed reviewers: + kbr@chromium.org
kbr: Please review. I've manually verified that WebGL is now correctly throttled under Image Chromium, using both FPS meter and chrome tracing.
Awesome! LGTM!
The CQ bit was checked by erikchen@chromium.org to run a CQ dry run
erikchen@chromium.org changed reviewers: + avi@chromium.org
avi: Please review content/
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2025973002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2025973002/40001
lgtm yay!
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by erikchen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2025973002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2025973002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
On 2016/06/02 22:21:48, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, > http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...) http://crbug.com/616548 . Re-CQ'ing.
The CQ bit was checked by kbr@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2025973002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2025973002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by erikchen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2025973002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2025973002/40001
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Re-enable WebGL Image Chromium. This CL makes DrawingBuffer use the newly added DescheduleUntilFinishedCHROMIUM, and turns on IOSurface backed WebGL by default. BUG=581777 ========== to ========== Re-enable WebGL Image Chromium. This CL makes DrawingBuffer use the newly added DescheduleUntilFinishedCHROMIUM, and turns on IOSurface backed WebGL by default. BUG=581777 Committed: https://crrev.com/801f15833c140f120a2f5baed88645cb0619ab86 Cr-Commit-Position: refs/heads/master@{#397603} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/801f15833c140f120a2f5baed88645cb0619ab86 Cr-Commit-Position: refs/heads/master@{#397603}
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/2041053002/ by erikchen@chromium.org. The reason for reverting is: I'm observing a behavior difference between the Image CHROMIUM and non-Image CHROMIUM path. Turning off Image CHROMIUM while I investigate. https://bugs.chromium.org/p/chromium/issues/detail?id=617249#c5. |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
