|
|
Created:
4 years, 6 months ago by erikchen Modified:
4 years, 6 months ago Reviewers:
Avi (use Gerrit) CC:
chromium-reviews, darin-cc_chromium.org, jam Base URL:
https://chromium.googlesource.com/chromium/src.git@temp68_enable_webgl Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionMove Canvas and WebGL Image Chromium behind experiments.
The experiments will be enabled on Canary and Dev channels.
BUG=616295
Committed: https://crrev.com/eaa3e1e13385f183df5d0fb38e0dd60057465436
Cr-Commit-Position: refs/heads/master@{#400860}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Comments from avi. #Patch Set 3 : #Patch Set 4 : Rebase. #Patch Set 5 : Rebase. #Patch Set 6 : Rebase. #Patch Set 7 : Compile errors. #
Messages
Total messages: 32 (16 generated)
erikchen@chromium.org changed reviewers: + avi@chromium.org
avi: Please review.
The CQ bit was checked by erikchen@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2023383004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2023383004/1
https://codereview.chromium.org/2023383004/diff/1/content/child/runtime_featu... File content/child/runtime_features.cc (right): https://codereview.chromium.org/2023383004/diff/1/content/child/runtime_featu... content/child/runtime_features.cc:36: } // namespace Other features in this file are defined in content/public/common/content_features.cc and referenced here (search this file for base::FeatureList::IsEnabled). Why do these live here?
https://codereview.chromium.org/2023383004/diff/1/content/child/runtime_featu... File content/child/runtime_features.cc (right): https://codereview.chromium.org/2023383004/diff/1/content/child/runtime_featu... content/child/runtime_features.cc:36: } // namespace On 2016/06/02 18:20:26, Avi wrote: > Other features in this file are defined in > content/public/common/content_features.cc and referenced here (search this file > for base::FeatureList::IsEnabled). Why do these live here? Didn't know about it. Fixed.
lgtm
The CQ bit was checked by erikchen@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2023383004/30001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2023383004/30001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_compile_dbg on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...) cast_shell_android on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...) ios-device on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-device-gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...) mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...) mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by erikchen@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from avi@chromium.org Link to the patchset: https://codereview.chromium.org/2023383004/#ps50001 (title: "Rebase.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2023383004/50001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2023383004/50001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by erikchen@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from avi@chromium.org Link to the patchset: https://codereview.chromium.org/2023383004/#ps70001 (title: "Rebase.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2023383004/70001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-simulator on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...) ios-simulator-gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...) mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
The CQ bit was checked by erikchen@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from avi@chromium.org Link to the patchset: https://codereview.chromium.org/2023383004/#ps90001 (title: "Rebase.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2023383004/90001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
The CQ bit was checked by erikchen@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from avi@chromium.org Link to the patchset: https://codereview.chromium.org/2023383004/#ps110001 (title: "Compile errors.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2023383004/110001
Message was sent while issue was closed.
Committed patchset #7 (id:110001)
Message was sent while issue was closed.
Description was changed from ========== Move Canvas and WebGL Image Chromium behind experiments. The experiments will be enabled on Canary and Dev channels. BUG=616295 ========== to ========== Move Canvas and WebGL Image Chromium behind experiments. The experiments will be enabled on Canary and Dev channels. BUG=616295 Committed: https://crrev.com/eaa3e1e13385f183df5d0fb38e0dd60057465436 Cr-Commit-Position: refs/heads/master@{#400860} ==========
Message was sent while issue was closed.
Patchset 7 (id:??) landed as https://crrev.com/eaa3e1e13385f183df5d0fb38e0dd60057465436 Cr-Commit-Position: refs/heads/master@{#400860} |