Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(974)

Issue 2023383004: Move Canvas and WebGL Image Chromium behind experiments. (Closed)

Created:
4 years, 6 months ago by erikchen
Modified:
4 years, 6 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@temp68_enable_webgl
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move Canvas and WebGL Image Chromium behind experiments. The experiments will be enabled on Canary and Dev channels. BUG=616295 Committed: https://crrev.com/eaa3e1e13385f183df5d0fb38e0dd60057465436 Cr-Commit-Position: refs/heads/master@{#400860}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Comments from avi. #

Patch Set 3 : #

Patch Set 4 : Rebase. #

Patch Set 5 : Rebase. #

Patch Set 6 : Rebase. #

Patch Set 7 : Compile errors. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -0 lines) Patch
M content/child/runtime_features.cc View 1 2 3 4 5 6 2 chunks +10 lines, -0 lines 0 comments Download
M content/public/common/content_features.h View 1 2 3 4 2 chunks +2 lines, -0 lines 0 comments Download
M content/public/common/content_features.cc View 1 2 3 4 2 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 32 (16 generated)
erikchen
avi: Please review.
4 years, 6 months ago (2016-06-02 18:12:51 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2023383004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2023383004/1
4 years, 6 months ago (2016-06-02 18:14:35 UTC) #4
Avi (use Gerrit)
https://codereview.chromium.org/2023383004/diff/1/content/child/runtime_features.cc File content/child/runtime_features.cc (right): https://codereview.chromium.org/2023383004/diff/1/content/child/runtime_features.cc#newcode36 content/child/runtime_features.cc:36: } // namespace Other features in this file are ...
4 years, 6 months ago (2016-06-02 18:20:27 UTC) #5
erikchen
https://codereview.chromium.org/2023383004/diff/1/content/child/runtime_features.cc File content/child/runtime_features.cc (right): https://codereview.chromium.org/2023383004/diff/1/content/child/runtime_features.cc#newcode36 content/child/runtime_features.cc:36: } // namespace On 2016/06/02 18:20:26, Avi wrote: > ...
4 years, 6 months ago (2016-06-02 19:45:26 UTC) #6
Avi (use Gerrit)
lgtm
4 years, 6 months ago (2016-06-02 19:48:56 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2023383004/30001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2023383004/30001
4 years, 6 months ago (2016-06-02 21:54:21 UTC) #9
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_compile_dbg on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_compile_dbg/builds/75940) cast_shell_android on ...
4 years, 6 months ago (2016-06-02 21:59:39 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2023383004/50001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2023383004/50001
4 years, 6 months ago (2016-06-03 14:27:19 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/213778) mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 6 months ago (2016-06-03 14:42:33 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2023383004/70001
4 years, 6 months ago (2016-06-20 23:51:50 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/23787) ios-simulator-gn on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 6 months ago (2016-06-20 23:53:40 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2023383004/90001
4 years, 6 months ago (2016-06-21 00:00:17 UTC) #24
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/221765)
4 years, 6 months ago (2016-06-21 00:14:18 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2023383004/110001
4 years, 6 months ago (2016-06-21 00:17:12 UTC) #29
commit-bot: I haz the power
Committed patchset #7 (id:110001)
4 years, 6 months ago (2016-06-21 01:05:05 UTC) #30
commit-bot: I haz the power
4 years, 6 months ago (2016-06-21 01:12:12 UTC) #32
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/eaa3e1e13385f183df5d0fb38e0dd60057465436
Cr-Commit-Position: refs/heads/master@{#400860}

Powered by Google App Engine
This is Rietveld 408576698