Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(524)

Issue 2025953002: DevTools: generate class-per domain for remote debugging protocol. (Closed)

Created:
4 years, 6 months ago by pfeldman
Modified:
4 years, 6 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, pfeldman+blink_chromium.org, lushnikov+blink_chromium.org, haraken, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: generate class-per domain for remote debugging protocol. BUG=580337 NOTRY=true Committed: https://crrev.com/556210b7bb7f75aa8f305d7175d1b3271bb21d5e Cr-Commit-Position: refs/heads/master@{#397326}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Patch Set 8 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+522 lines, -230 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/SourceLocation.cpp View 1 2 3 4 5 6 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/BUILD.gn View 1 2 3 4 5 6 4 chunks +32 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/core.gyp View 1 4 chunks +6 lines, -34 lines 0 comments Download
M third_party/WebKit/Source/core/core.gypi View 1 2 3 4 5 6 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/core_generated.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/core_generated.gypi View 1 2 3 4 5 2 chunks +30 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/BUILD.gn View 1 2 3 4 5 6 1 chunk +84 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/DOMEditor.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.h View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorApplicationCacheAgent.h View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorBaseAgent.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorCSSAgent.h View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorConsoleAgent.h View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorDOMAgent.h View 1 2 3 4 5 3 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp View 1 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.h View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorHighlight.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorInputAgent.h View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorLayerTreeAgent.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorMemoryAgent.h View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorPageAgent.h View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorResourceAgent.h View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorSession.cpp View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorStyleSheet.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorTracingAgent.h View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorWorkerAgent.h View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
A third_party/WebKit/Source/core/inspector/inspector.gyp View 1 2 3 4 5 6 1 chunk +132 lines, -0 lines 0 comments Download
A + third_party/WebKit/Source/core/inspector/protocol/Debugger.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/core/inspector/protocol/HeapProfiler.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/core/inspector/protocol/Profiler.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/core/inspector/protocol/Runtime.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/protocol.json View 1 2 3 4 5 18 chunks +21 lines, -19 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXObject.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.h View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/InspectorTypeBuilderHelper.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/accessibility/InspectorTypeBuilderHelper.cpp View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/cachestorage/InspectorCacheStorageAgent.h View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/cachestorage/InspectorCacheStorageAgent.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/device_orientation/DeviceOrientationInspectorAgent.h View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/InspectorIndexedDBAgent.h View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/storage/InspectorDOMStorageAgent.h View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/InspectorDatabaseAgent.h View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/InspectorDatabaseResource.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/BUILD.gn View 1 2 3 4 5 6 3 chunks +19 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/platform/blink_platform.gyp View 1 2 3 4 5 1 chunk +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/CodeGenerator.py View 1 2 3 4 5 6 7 chunks +44 lines, -56 lines 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/DispatcherBase.h View 1 2 3 4 5 6 7 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/DispatcherBase.cpp View 1 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/ErrorSupport.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/Maybe.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/TypeBuilder_cpp.template View 1 2 3 4 5 6 3 chunks +3 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/TypeBuilder_h.template View 1 2 3 4 5 6 11 chunks +20 lines, -19 lines 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/protocol.gyp View 1 2 chunks +0 lines, -38 lines 0 comments Download
M third_party/WebKit/Source/platform/platform_generated.gyp View 1 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/InjectedScript.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/RemoteObjectId.h View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.h View 1 2 3 4 5 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8HeapProfilerAgentImpl.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/public/V8ContentSearchUtil.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/public/V8InspectorSession.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/public/V8StackTrace.h View 1 2 3 4 5 6 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/v8_inspector.gyp View 1 2 3 4 5 6 2 chunks +48 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/InspectorEmulationAgent.h View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/web/InspectorOverlay.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/InspectorRenderingAgent.h View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerRegistrationProxy.h View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 45 (25 generated)
pfeldman
4 years, 6 months ago (2016-06-01 00:18:48 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2025953002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2025953002/20001
4 years, 6 months ago (2016-06-01 00:20:02 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_chromium_compile_only_ng/builds/145787)
4 years, 6 months ago (2016-06-01 00:38:20 UTC) #6
dgozman
lgtm
4 years, 6 months ago (2016-06-01 01:40:59 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2025953002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2025953002/60001
4 years, 6 months ago (2016-06-01 01:58:34 UTC) #9
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/198950)
4 years, 6 months ago (2016-06-01 03:13:33 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2025953002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2025953002/80001
4 years, 6 months ago (2016-06-01 05:04:25 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-generic_chromium_compile_only_ng/builds/145893)
4 years, 6 months ago (2016-06-01 05:15:00 UTC) #16
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2025953002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2025953002/100001
4 years, 6 months ago (2016-06-01 06:12:29 UTC) #18
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_chromium_compile_only_ng/builds/145938)
4 years, 6 months ago (2016-06-01 06:28:02 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2025953002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2025953002/120001
4 years, 6 months ago (2016-06-02 00:05:08 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: win_clang on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/31184)
4 years, 6 months ago (2016-06-02 01:31:05 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2025953002/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2025953002/140001
4 years, 6 months ago (2016-06-02 01:36:04 UTC) #28
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_rel/builds/120766)
4 years, 6 months ago (2016-06-02 02:04:27 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2025953002/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2025953002/140001
4 years, 6 months ago (2016-06-02 03:24:37 UTC) #32
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_rel/builds/120822)
4 years, 6 months ago (2016-06-02 03:37:19 UTC) #34
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2025953002/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2025953002/140001
4 years, 6 months ago (2016-06-02 05:23:35 UTC) #36
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2025953002/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2025953002/140001
4 years, 6 months ago (2016-06-02 07:03:16 UTC) #41
commit-bot: I haz the power
Committed patchset #8 (id:140001)
4 years, 6 months ago (2016-06-02 07:09:35 UTC) #43
commit-bot: I haz the power
4 years, 6 months ago (2016-06-02 07:10:42 UTC) #45
Message was sent while issue was closed.
Patchset 8 (id:??) landed as
https://crrev.com/556210b7bb7f75aa8f305d7175d1b3271bb21d5e
Cr-Commit-Position: refs/heads/master@{#397326}

Powered by Google App Engine
This is Rietveld 408576698