third_party/WebKit/Source/core/inspector/InspectorDOMAgent.h - Issue 2025953002: DevTools: generate class-per domain for remote debugging protocol.

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorDOMAgent.h

Issue 2025953002: DevTools: generate class-per domain for remote debugging protocol. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/InspectorConsoleAgent.h ('k') | third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/InspectorDOMAgent.h

diff --git a/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.h b/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.h

index a5f16f923344dbcfc9d4b88468e7362e27837c83..59c0e0c057ed31dda0a83c50d9f7b6660e512ecc 100644

--- a/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.h

+++ b/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.h

@@ -34,6 +34,7 @@

#include "core/events/EventListenerMap.h"

#include "core/inspector/InspectorBaseAgent.h"

#include "core/inspector/InspectorHighlight.h"

+#include "core/inspector/protocol/DOM.h"

#include "core/style/ComputedStyleConstants.h"

#include "platform/geometry/FloatQuad.h"

#include "platform/inspector_protocol/Values.h"

@@ -125,11 +126,11 @@ public:

void performSearch(ErrorString*, const String& query, const Maybe<bool>& includeUserAgentShadowDOM, String* searchId, int* resultCount) override;

void getSearchResults(ErrorString*, const String& searchId, int fromIndex, int toIndex, std::unique_ptr<protocol::Array<int>>* nodeIds) override;

void discardSearchResults(ErrorString*, const String& searchId) override;

- void requestNode(ErrorString*, const String16& objectId, int* outNodeId) override;

+ void requestNode(ErrorString*, const String& objectId, int* outNodeId) override;

void setInspectMode(ErrorString*, const String& mode, const Maybe<protocol::DOM::HighlightConfig>&) override;

void highlightRect(ErrorString*, int x, int y, int width, int height, const Maybe<protocol::DOM::RGBA>& color, const Maybe<protocol::DOM::RGBA>& outlineColor) override;

void highlightQuad(ErrorString*, std::unique_ptr<protocol::Array<double>> quad, const Maybe<protocol::DOM::RGBA>& color, const Maybe<protocol::DOM::RGBA>& outlineColor) override;

- void highlightNode(ErrorString*, std::unique_ptr<protocol::DOM::HighlightConfig>, const Maybe<int>& nodeId, const Maybe<int>& backendNodeId, const Maybe<String16>& objectId) override;

+ void highlightNode(ErrorString*, std::unique_ptr<protocol::DOM::HighlightConfig>, const Maybe<int>& nodeId, const Maybe<int>& backendNodeId, const Maybe<String>& objectId) override;

void hideHighlight(ErrorString*) override;

void highlightFrame(ErrorString*, const String& frameId, const Maybe<protocol::DOM::RGBA>& contentColor, const Maybe<protocol::DOM::RGBA>& contentOutlineColor) override;

void pushNodeByPathToFrontend(ErrorString*, const String& path, int* outNodeId) override;

@@ -178,7 +179,7 @@ public:

static String documentURLString(Document*);

- std::unique_ptr<protocol::Runtime::RemoteObject> resolveNode(Node*, const String16& objectGroup);

+ std::unique_ptr<protocol::Runtime::RemoteObject> resolveNode(Node*, const String& objectGroup);

InspectorHistory* history() { return m_history.get(); }