Drop deprecation message for xhr.withCredentials for sync requests

Drop deprecation message for xhr.withCredentials for sync requests

The spec was changed due to a compat problem in Gecko, and Gecko has
already changed as well, "since no one except for us bothered to
implement the spec":
https://bugzilla.mozilla.org/show_bug.cgi?id=1260515
https://github.com/whatwg/xhr/issues/66

Intent to Deprecate thread updated:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/BOgLhbdljU4

BUG=383483
Committed: https://crrev.com/5a7c5b314edf179e2831b17564418a2071d239bd
Cr-Commit-Position: refs/heads/master@{#397085}

[foolip, 2016-05-31 14:18:38]

The CQ bit was checked by foolip@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-31 14:18:53]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2025903002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2025903002/1

[foolip, 2016-05-31 14:21:55]

Description was changed from

==========
Drop deprecation message for xhr.withCredentials for sync requests

The spec was changed due to a compat problem in Gecko, and Gecko has
already changed as well, "since no one except for us bothered to
implement the spec":
https://bugzilla.mozilla.org/show_bug.cgi?id=1260515
https://github.com/whatwg/xhr/issues/66

Intent to Deprecate:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/BOgLhbdljU4

BUG=383483
==========

to

==========
Drop deprecation message for xhr.withCredentials for sync requests

The spec was changed due to a compat problem in Gecko, and Gecko has
already changed as well, "since no one except for us bothered to
implement the spec":
https://bugzilla.mozilla.org/show_bug.cgi?id=1260515
https://github.com/whatwg/xhr/issues/66

Intent to Deprecate thread updated:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/BOgLhbdljU4

BUG=383483
==========

[commit-bot: I haz the power, 2016-05-31 16:00:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-31 16:00:27]

Dry run: This issue passed the CQ dry run.

[foolip, 2016-05-31 20:07:17]

foolip@chromium.org changed reviewers:
+ jochen@chromium.org, sigbjornf@opera.com, tyoshino@chromium.org

[foolip, 2016-05-31 20:07:18]

PTAL, and please confirm that this will not create trouble for
https://crbug.com/607497 (if so then more discussion is needed I guess)

[sof, 2016-05-31 20:32:20]

The restriction was added to the spec originally as a sync XHR deprecation
tactic, nothing more afair. And some time after withCredentials was added as an
XHR attribute.

With the spec retiring this as a not-sufficiently-adopted feature, then let's
move along and align with that. And do better next time.

https://codereview.chromium.org/2025903002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/frame/UseCounter.h (left):

https://codereview.chromium.org/2025903002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/frame/UseCounter.h:375: SyncXHRWithCredentials =
472,
What's the procedure to follow wrt updating tools/metrics/histograms/ when
retiring a counter?

[foolip, 2016-05-31 21:45:53]

https://codereview.chromium.org/2025903002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/frame/UseCounter.h (left):

https://codereview.chromium.org/2025903002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/frame/UseCounter.h:375: SyncXHRWithCredentials =
472,
On 2016/05/31 20:32:20, sof wrote:
> What's the procedure to follow wrt updating tools/metrics/histograms/ when
> retiring a counter?

They aren't removed by running the script, and all entries I've removed or seen
removed have remained in histograms.xml. It would be nice if the fact that it's
been removed were somehow propagated to https://www.chromestatus.com/ but my one
and only attempt at this didn't go too well:
https://github.com/GoogleChrome/chromium-dashboard/pull/129

[sof, 2016-06-01 05:34:16]

lgtm from my side.

https://codereview.chromium.org/2025903002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/frame/UseCounter.h (left):

https://codereview.chromium.org/2025903002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/frame/UseCounter.h:375: SyncXHRWithCredentials =
472,
On 2016/05/31 21:45:53, Philip Jägenstedt wrote:
> On 2016/05/31 20:32:20, sof wrote:
> > What's the procedure to follow wrt updating tools/metrics/histograms/ when
> > retiring a counter?
> 
> They aren't removed by running the script, and all entries I've removed or
seen
> removed have remained in histograms.xml. It would be nice if the fact that
it's
> been removed were somehow propagated to https://www.chromestatus.com/ but my
one
> and only attempt at this didn't go too well:
> https://github.com/GoogleChrome/chromium-dashboard/pull/129

ok, there'll be a major GC when the list becomes too littered with empty ones, i
guess.

[tyoshino (SeeGerritForStatus), 2016-06-01 06:47:29]

lgtm

[foolip, 2016-06-01 06:56:20]

https://codereview.chromium.org/2025903002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/frame/UseCounter.h (left):

https://codereview.chromium.org/2025903002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/frame/UseCounter.h:375: SyncXHRWithCredentials =
472,
On 2016/06/01 05:34:16, sof wrote:
> On 2016/05/31 21:45:53, Philip Jägenstedt wrote:
> > On 2016/05/31 20:32:20, sof wrote:
> > > What's the procedure to follow wrt updating tools/metrics/histograms/ when
> > > retiring a counter?
> > 
> > They aren't removed by running the script, and all entries I've removed or
> seen
> > removed have remained in histograms.xml. It would be nice if the fact that
> it's
> > been removed were somehow propagated to https://www.chromestatus.com/ but my
> one
> > and only attempt at this didn't go too well:
> > https://github.com/GoogleChrome/chromium-dashboard/pull/129
> 
> ok, there'll be a major GC when the list becomes too littered with empty ones,
i
> guess.

Yeah. The way I hope it works out is that each counter gets milestones attached
to it for when it was added, deprecated and removed, that would show up in the
graphs.

[jochen (gone - plz use gerrit), 2016-06-01 08:07:14]

lgtm

[foolip, 2016-06-01 08:49:32]

The CQ bit was checked by foolip@chromium.org

[commit-bot: I haz the power, 2016-06-01 08:49:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2025903002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2025903002/1

[commit-bot: I haz the power, 2016-06-01 08:53:55]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-06-01 08:55:09]

Description was changed from

==========
Drop deprecation message for xhr.withCredentials for sync requests

The spec was changed due to a compat problem in Gecko, and Gecko has
already changed as well, "since no one except for us bothered to
implement the spec":
https://bugzilla.mozilla.org/show_bug.cgi?id=1260515
https://github.com/whatwg/xhr/issues/66

Intent to Deprecate thread updated:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/BOgLhbdljU4

BUG=383483
==========

to

==========
Drop deprecation message for xhr.withCredentials for sync requests

The spec was changed due to a compat problem in Gecko, and Gecko has
already changed as well, "since no one except for us bothered to
implement the spec":
https://bugzilla.mozilla.org/show_bug.cgi?id=1260515
https://github.com/whatwg/xhr/issues/66

Intent to Deprecate thread updated:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/BOgLhbdljU4

BUG=383483

Committed: https://crrev.com/5a7c5b314edf179e2831b17564418a2071d239bd
Cr-Commit-Position: refs/heads/master@{#397085}
==========

[commit-bot: I haz the power, 2016-06-01 08:55:10]

Patchset 1 (id:??) landed as
https://crrev.com/5a7c5b314edf179e2831b17564418a2071d239bd
Cr-Commit-Position: refs/heads/master@{#397085}