Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(446)

Unified Diff: third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp

Issue 2025903002: Drop deprecation message for xhr.withCredentials for sync requests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp
diff --git a/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp b/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp
index ebc7cf94c16b190ec6f153a09aa62f44028953a9..3104ef644f480bd863dbb5330586ba7e67672aef 100644
--- a/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp
+++ b/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp
@@ -530,11 +530,6 @@ void XMLHttpRequest::setWithCredentials(bool value, ExceptionState& exceptionSta
return;
}
- // FIXME: According to XMLHttpRequest Level 2 we should throw InvalidAccessError exception here.
- // However for time being only print warning message to warn web developers.
- if (!m_async)
- Deprecation::countDeprecation(getExecutionContext(), UseCounter::SyncXHRWithCredentials);
-
m_includeCredentials = value;
}

Powered by Google App Engine
This is Rietveld 408576698