Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 2025793004: mac/gn: Add most missing test binaries to the gn build. (Closed)

Created:
4 years, 6 months ago by Nico
Modified:
4 years, 6 months ago
CC:
chromium-reviews, sdefresne
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mac/gn: Add most missing test binaries to the gn build. BUG=612580 TBR=dpranke Committed: https://crrev.com/507c15c418df6f643c990e06a1d989eafab85fc1 Cr-Commit-Position: refs/heads/master@{#396990}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M BUILD.gn View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Nico
This seems to Just Work. (sdefresne: FYI; you'll need to do this on ios too)
4 years, 6 months ago (2016-05-31 22:21:15 UTC) #2
Robert Sesek
LGTM
4 years, 6 months ago (2016-05-31 22:22:58 UTC) #3
Nico
tbr dpranke for toplevel BUILD.gn owners
4 years, 6 months ago (2016-05-31 22:23:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2025793004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2025793004/1
4 years, 6 months ago (2016-05-31 22:41:53 UTC) #8
Dirk Pranke
lgtm
4 years, 6 months ago (2016-05-31 22:49:56 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-01 00:26:12 UTC) #11
commit-bot: I haz the power
4 years, 6 months ago (2016-06-01 00:27:28 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/507c15c418df6f643c990e06a1d989eafab85fc1
Cr-Commit-Position: refs/heads/master@{#396990}

Powered by Google App Engine
This is Rietveld 408576698