Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Unified Diff: BUILD.gn

Issue 2025793004: mac/gn: Add most missing test binaries to the gn build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index 5e9ba95ee6764ee21c65f271f0a1eb1dfcf97e07..651e349898942bdc2fa4d52cc74cc12238ae2414 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -432,7 +432,9 @@ group("both_gn_and_gyp") {
]
}
- if (is_android || is_win || (is_linux && !is_chromeos)) {
+ # TODO(GYP): Figure out which of these should (and can) build
+ # for chromeos/ios.
+ if (!is_chromeos && !is_ios) {
deps += [
"//base:build_utf8_validator_tables",
"//base:check_example",
@@ -455,8 +457,6 @@ group("both_gn_and_gyp") {
"//ui/compositor:compositor_unittests",
]
- # TODO(GYP): Figure out which of these should (and can) build
- # for chromeos/mac/ios.
if (!is_android) {
deps += [
"//chrome/test:load_library_perf_tests",
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698