third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.h - Issue 2025703002: Pack repeated code in tex(Sub)Image2D and texSubImage3D into helper func

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.h

Issue 2025703002: Pack repeated code in tex(Sub)Image2D and texSubImage3D into helper func (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: pass enum instead of const char*, use a wrapper for validate2D(3D)Binding Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp » ('j') | third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.h

diff --git a/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.h b/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.h

index 05f34990b621ef4b688365ad63ef979baacbb049..7c39ae7989cac505d68586e21309cdf2474b5952 100644

--- a/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.h

+++ b/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.h

@@ -263,6 +263,7 @@ protected:

GLint getMaxTextureLevelForTarget(GLenum target) override;

void renderbufferStorageImpl(GLenum target, GLsizei samples, GLenum internalformat, GLsizei width, GLsizei height, const char* functionName) override;

+ WebGLTexture* validateTexImageBinding(const char*, TexImageFunctionName, GLenum) override;

// Helper function to check texture 3D target and texture bound to the target.

// Generate GL errors and return 0 if target is invalid or texture bound is

// null. Otherwise, return the texture bound to the target.