third_party/WebKit/Source/modules/webgl/WebGLRenderingContext.h - Issue 2025703002: Pack repeated code in tex(Sub)Image2D and texSubImage3D into helper func

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webgl/WebGLRenderingContext.h

Issue 2025703002: Pack repeated code in tex(Sub)Image2D and texSubImage3D into helper func (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: make validateTexture3DBinding pure virtual in WebGLBase Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp ('k') | third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h » ('j') | third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webgl/WebGLRenderingContext.h

diff --git a/third_party/WebKit/Source/modules/webgl/WebGLRenderingContext.h b/third_party/WebKit/Source/modules/webgl/WebGLRenderingContext.h

index bd12bf13dc5d2de9f75df2e808a6c49e70e56166..8dd4da88fe17a9105f1de8ceeb8340893cff85c8 100644

--- a/third_party/WebKit/Source/modules/webgl/WebGLRenderingContext.h

+++ b/third_party/WebKit/Source/modules/webgl/WebGLRenderingContext.h

@@ -57,6 +57,7 @@ public:

void registerContextExtensions() override;

void setCanvasGetContextResult(RenderingContext&) final;

void setOffscreenCanvasGetContextResult(OffscreenRenderingContext&) final;

+ WebGLTexture* validateTexture3DBinding(const char* functionName, GLenum target) final { return nullptr; }

EAGERLY_FINALIZE();

DECLARE_VIRTUAL_TRACE();