Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Side by Side Diff: third_party/WebKit/Source/modules/webgl/WebGLRenderingContext.h

Issue 2025703002: Pack repeated code in tex(Sub)Image2D and texSubImage3D into helper func (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: make validateTexture3DBinding pure virtual in WebGLBase Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Apple Inc. All rights reserved. 2 * Copyright (C) 2009 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
50 50
51 ~WebGLRenderingContext() override; 51 ~WebGLRenderingContext() override;
52 52
53 CanvasRenderingContext::ContextType getContextType() const override { return CanvasRenderingContext::ContextWebgl; } 53 CanvasRenderingContext::ContextType getContextType() const override { return CanvasRenderingContext::ContextWebgl; }
54 ImageBitmap* transferToImageBitmap(ExceptionState&) final; 54 ImageBitmap* transferToImageBitmap(ExceptionState&) final;
55 unsigned version() const override { return 1; } 55 unsigned version() const override { return 1; }
56 String contextName() const override { return "WebGLRenderingContext"; } 56 String contextName() const override { return "WebGLRenderingContext"; }
57 void registerContextExtensions() override; 57 void registerContextExtensions() override;
58 void setCanvasGetContextResult(RenderingContext&) final; 58 void setCanvasGetContextResult(RenderingContext&) final;
59 void setOffscreenCanvasGetContextResult(OffscreenRenderingContext&) final; 59 void setOffscreenCanvasGetContextResult(OffscreenRenderingContext&) final;
60 WebGLTexture* validateTexture3DBinding(const char* functionName, GLenum targ et) final { return nullptr; }
60 61
61 EAGERLY_FINALIZE(); 62 EAGERLY_FINALIZE();
62 DECLARE_VIRTUAL_TRACE(); 63 DECLARE_VIRTUAL_TRACE();
63 64
64 DECLARE_VIRTUAL_TRACE_WRAPPERS(); 65 DECLARE_VIRTUAL_TRACE_WRAPPERS();
65 66
66 private: 67 private:
67 WebGLRenderingContext(HTMLCanvasElement*, PassOwnPtr<WebGraphicsContext3DPro vider>, const WebGLContextAttributes&); 68 WebGLRenderingContext(HTMLCanvasElement*, PassOwnPtr<WebGraphicsContext3DPro vider>, const WebGLContextAttributes&);
68 WebGLRenderingContext(OffscreenCanvas*, PassOwnPtr<WebGraphicsContext3DProvi der>, const WebGLContextAttributes&); 69 WebGLRenderingContext(OffscreenCanvas*, PassOwnPtr<WebGraphicsContext3DProvi der>, const WebGLContextAttributes&);
69 70
(...skipping 24 matching lines...) Expand all
94 Member<WebGLDepthTexture> m_webglDepthTexture; 95 Member<WebGLDepthTexture> m_webglDepthTexture;
95 }; 96 };
96 97
97 DEFINE_TYPE_CASTS(WebGLRenderingContext, CanvasRenderingContext, context, 98 DEFINE_TYPE_CASTS(WebGLRenderingContext, CanvasRenderingContext, context,
98 context->is3d() && WebGLRenderingContextBase::getWebGLVersion(context) == 1, 99 context->is3d() && WebGLRenderingContextBase::getWebGLVersion(context) == 1,
99 context.is3d() && WebGLRenderingContextBase::getWebGLVersion(&context) == 1) ; 100 context.is3d() && WebGLRenderingContextBase::getWebGLVersion(&context) == 1) ;
100 101
101 } // namespace blink 102 } // namespace blink
102 103
103 #endif // WebGLRenderingContext_h 104 #endif // WebGLRenderingContext_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698