command_buffer: expose SRC_ALPHA_SATURATE when on GLES 3

command_buffer: expose SRC_ALPHA_SATURATE when on GLES 3

BUG=614504
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/c026ebf7a44d263bdbc6df3e5ba9b480ff6c6ac9
Cr-Commit-Position: refs/heads/master@{#396918}

[Corentin Wallez, 2016-05-30 19:55:00]

Description was changed from

==========
command_buffer: expose SRC_ALPHA_SATURATE when on GLES 3

BUG=614504
==========

to

==========
command_buffer: expose SRC_ALPHA_SATURATE when on GLES 3

BUG=614504
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Corentin Wallez, 2016-05-30 19:56:21]

cwallez@chromium.org changed reviewers:
+ kbr@chromium.org, zmo@chromium.org

[Corentin Wallez, 2016-05-30 19:56:21]

PTAL, this fixes integer state queries on Windows when using ANGLE so the test
can be enabled everywhere.

[Zhenyao Mo, 2016-05-31 02:05:31]

https://codereview.chromium.org/2025673003/diff/1/gpu/command_buffer/service/...
File gpu/command_buffer/service/feature_info.cc (right):

https://codereview.chromium.org/2025673003/diff/1/gpu/command_buffer/service/...
gpu/command_buffer/service/feature_info.cc:1257:
validators_.dst_blend_factor.AddValue(GL_SRC_ALPHA_SATURATE);
This isn't the right fix for this.

Instead, you should add the enum to the "valid_es3" in "DstBlendFactor" in
build_gles2_cmd_buffer.py

[Corentin Wallez, 2016-05-31 14:09:42]

On 2016/05/31 at 02:05:31, zmo wrote:
>
https://codereview.chromium.org/2025673003/diff/1/gpu/command_buffer/service/...
> File gpu/command_buffer/service/feature_info.cc (right):
> 
>
https://codereview.chromium.org/2025673003/diff/1/gpu/command_buffer/service/...
> gpu/command_buffer/service/feature_info.cc:1257:
validators_.dst_blend_factor.AddValue(GL_SRC_ALPHA_SATURATE);
> This isn't the right fix for this.
> 
> Instead, you should add the enum to the "valid_es3" in "DstBlendFactor" in
build_gles2_cmd_buffer.py

Thanks, that's the proper fix I have been looking for! Done.

[Zhenyao Mo, 2016-05-31 15:41:29]

lgtm

[Corentin Wallez, 2016-05-31 17:59:17]

On 2016/05/31 at 15:41:29, zmo wrote:
> lgtm

Thanks, checked that the new version fixes the problem on Windows.

[Corentin Wallez, 2016-05-31 17:59:19]

The CQ bit was checked by cwallez@chromium.org

[commit-bot: I haz the power, 2016-05-31 17:59:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2025673003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2025673003/20001

[commit-bot: I haz the power, 2016-05-31 20:34:30]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-31 20:45:25]

Description was changed from

==========
command_buffer: expose SRC_ALPHA_SATURATE when on GLES 3

BUG=614504
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
command_buffer: expose SRC_ALPHA_SATURATE when on GLES 3

BUG=614504
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/c026ebf7a44d263bdbc6df3e5ba9b480ff6c6ac9
Cr-Commit-Position: refs/heads/master@{#396918}
==========

[commit-bot: I haz the power, 2016-05-31 20:45:27]

Patchset 2 (id:??) landed as
https://crrev.com/c026ebf7a44d263bdbc6df3e5ba9b480ff6c6ac9
Cr-Commit-Position: refs/heads/master@{#396918}