command_buffer: expose SRC_ALPHA_SATURATE when on GLES 3

gpu/command_buffer/service/feature_info.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "gpu/command_buffer/service/feature_info.h"
 
 #include <stddef.h>
 
 #include <set>
 #include <vector>
@@ skipping 1231 matching lines @@
     validators_.render_buffer_format.AddValue(GL_RG8_EXT);
     validators_.texture_unsized_internal_format.AddValue(GL_RED_EXT);
     validators_.texture_unsized_internal_format.AddValue(GL_RG_EXT);
   }
   UMA_HISTOGRAM_BOOLEAN("GPU.TextureRG", feature_flags_.ext_texture_rg);
 
   bool has_opengl_dual_source_blending =
       gl_version_info_->IsAtLeastGL(3, 3) ||
       (gl_version_info_->IsAtLeastGL(3, 2) &&
        extensions.Contains("GL_ARB_blend_func_extended"));
+
+  if (gl_version_info_->IsAtLeastGLES(3, 0) ||
+      has_opengl_dual_source_blending) {
+    // NOTE: SRC_ALPHA_SATURATE is valid for ES2 src blend factor.
+    // SRC_ALPHA_SATURATE is valid for ES3 src and dst blend factor.
+    validators_.dst_blend_factor.AddValue(GL_SRC_ALPHA_SATURATE);

[Zhenyao Mo, 2016/05/31 02:05:30]

This isn't the right fix for this.

Instead, you should add the enum to the "valid_es3" in "DstBlendFactor" in
build_gles2_cmd_buffer.py

+  }
+
   if (!disable_shader_translator_ &&
-      ((gl_version_info_->IsAtLeastGL(3, 2) &&
-        has_opengl_dual_source_blending) ||
+      (has_opengl_dual_source_blending ||
        (gl_version_info_->IsAtLeastGLES(3, 0) &&
         extensions.Contains("GL_EXT_blend_func_extended")))) {
     // Note: to simplify the code, we do not expose EXT_blend_func_extended
     // unless the service context supports ES 3.0. This means the theoretical ES
     // 2.0 implementation with EXT_blend_func_extended is not sufficient.
     feature_flags_.ext_blend_func_extended = true;
     AddExtensionString("GL_EXT_blend_func_extended");
 
-    // NOTE: SRC_ALPHA_SATURATE is valid for ES2 src blend factor.
-    // SRC_ALPHA_SATURATE is valid for ES3 src and dst blend factor.
-    validators_.dst_blend_factor.AddValue(GL_SRC_ALPHA_SATURATE_EXT);
-
     validators_.src_blend_factor.AddValue(GL_SRC1_ALPHA_EXT);
     validators_.dst_blend_factor.AddValue(GL_SRC1_ALPHA_EXT);
     validators_.src_blend_factor.AddValue(GL_SRC1_COLOR_EXT);
     validators_.dst_blend_factor.AddValue(GL_SRC1_COLOR_EXT);
     validators_.src_blend_factor.AddValue(GL_ONE_MINUS_SRC1_COLOR_EXT);
     validators_.dst_blend_factor.AddValue(GL_ONE_MINUS_SRC1_COLOR_EXT);
     validators_.src_blend_factor.AddValue(GL_ONE_MINUS_SRC1_ALPHA_EXT);
     validators_.dst_blend_factor.AddValue(GL_ONE_MINUS_SRC1_ALPHA_EXT);
     validators_.g_l_state.AddValue(GL_MAX_DUAL_SOURCE_DRAW_BUFFERS_EXT);
   }
@@ skipping 117 matching lines @@
   if (pos == std::string::npos) {
     extensions_ += (extensions_.empty() ? "" : " ") + str;
   }
 }
 
 FeatureInfo::~FeatureInfo() {
 }
 
 }  // namespace gles2
 }  // namespace gpu