[Sync] Clean up Android test code a bit, take 2.

[Sync] Clean up Android test code a bit, take 2.

Reland of http://crrev.com/2009603005. It was reverted because of a minor
FindBugs issue.

- Remove SigninTestUtil.get() and make it a fully static class.
- Add SigninTestUtil.getCurrentAccount() for convenience.
- setUpTestAccountAndSignInToSync -> setUpTestAccountAndSignIn because there's
  no such thing as signing in to sync.
- Remove SyncTestUtil.verify* and replace with asserts on SyncTestUtil.isSyncRequested
  and SigninTestUtil.getCurrentAccount.
- Make PassphraseTypeDialogFragmentTest inherit from SyncTestBase to resolve
  a flake related to signin state.

TBR=nyquist@chromium.org
BUG=

Committed: https://crrev.com/a88f601af0666ad721b2d4e0e39bbd8a17470d41
Cr-Commit-Position: refs/heads/master@{#396728}

[maxbogue, 2016-05-30 14:55:53]

Description was changed from

==========
[Sync] Clean up Android test code a bit, take 2.

Reland of http://crrev.com/2009603005. It was reverted because of a minor
FindBugs issue.

- Remove SigninTestUtil.get() and make it a fully static class.
- Add SigninTestUtil.getCurrentAccount() for convenience.
- setUpTestAccountAndSignInToSync -> setUpTestAccountAndSignIn because there's
  no such thing as signing in to sync.
- Remove SyncTestUtil.verify* and replace with asserts on
SyncTestUtil.isSyncRequested
  and SigninTestUtil.getCurrentAccount.
- Make PassphraseTypeDialogFragmentTest inherit from SyncTestBase to resolve
  a flake related to signin state.

BUG=
==========

to

==========
[Sync] Clean up Android test code a bit, take 2.

Reland of http://crrev.com/2009603005. It was reverted because of a minor
FindBugs issue.

- Remove SigninTestUtil.get() and make it a fully static class.
- Add SigninTestUtil.getCurrentAccount() for convenience.
- setUpTestAccountAndSignInToSync -> setUpTestAccountAndSignIn because there's
  no such thing as signing in to sync.
- Remove SyncTestUtil.verify* and replace with asserts on
SyncTestUtil.isSyncRequested
  and SigninTestUtil.getCurrentAccount.
- Make PassphraseTypeDialogFragmentTest inherit from SyncTestBase to resolve
  a flake related to signin state.

TBR=nyquist@chromium.org
BUG=
==========

[maxbogue, 2016-05-30 14:56:03]

The CQ bit was checked by maxbogue@chromium.org

[commit-bot: I haz the power, 2016-05-30 14:56:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2025653002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2025653002/20001

[commit-bot: I haz the power, 2016-05-30 15:00:51]

Description was changed from

==========
[Sync] Clean up Android test code a bit, take 2.

Reland of http://crrev.com/2009603005. It was reverted because of a minor
FindBugs issue.

- Remove SigninTestUtil.get() and make it a fully static class.
- Add SigninTestUtil.getCurrentAccount() for convenience.
- setUpTestAccountAndSignInToSync -> setUpTestAccountAndSignIn because there's
  no such thing as signing in to sync.
- Remove SyncTestUtil.verify* and replace with asserts on
SyncTestUtil.isSyncRequested
  and SigninTestUtil.getCurrentAccount.
- Make PassphraseTypeDialogFragmentTest inherit from SyncTestBase to resolve
  a flake related to signin state.

TBR=nyquist@chromium.org
BUG=
==========

to

==========
[Sync] Clean up Android test code a bit, take 2.

Reland of http://crrev.com/2009603005. It was reverted because of a minor
FindBugs issue.

- Remove SigninTestUtil.get() and make it a fully static class.
- Add SigninTestUtil.getCurrentAccount() for convenience.
- setUpTestAccountAndSignInToSync -> setUpTestAccountAndSignIn because there's
  no such thing as signing in to sync.
- Remove SyncTestUtil.verify* and replace with asserts on
SyncTestUtil.isSyncRequested
  and SigninTestUtil.getCurrentAccount.
- Make PassphraseTypeDialogFragmentTest inherit from SyncTestBase to resolve
  a flake related to signin state.

TBR=nyquist@chromium.org
BUG=
==========

[commit-bot: I haz the power, 2016-05-30 15:00:52]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-30 15:03:52]

Description was changed from

==========
[Sync] Clean up Android test code a bit, take 2.

Reland of http://crrev.com/2009603005. It was reverted because of a minor
FindBugs issue.

- Remove SigninTestUtil.get() and make it a fully static class.
- Add SigninTestUtil.getCurrentAccount() for convenience.
- setUpTestAccountAndSignInToSync -> setUpTestAccountAndSignIn because there's
  no such thing as signing in to sync.
- Remove SyncTestUtil.verify* and replace with asserts on
SyncTestUtil.isSyncRequested
  and SigninTestUtil.getCurrentAccount.
- Make PassphraseTypeDialogFragmentTest inherit from SyncTestBase to resolve
  a flake related to signin state.

TBR=nyquist@chromium.org
BUG=
==========

to

==========
[Sync] Clean up Android test code a bit, take 2.

Reland of http://crrev.com/2009603005. It was reverted because of a minor
FindBugs issue.

- Remove SigninTestUtil.get() and make it a fully static class.
- Add SigninTestUtil.getCurrentAccount() for convenience.
- setUpTestAccountAndSignInToSync -> setUpTestAccountAndSignIn because there's
  no such thing as signing in to sync.
- Remove SyncTestUtil.verify* and replace with asserts on
SyncTestUtil.isSyncRequested
  and SigninTestUtil.getCurrentAccount.
- Make PassphraseTypeDialogFragmentTest inherit from SyncTestBase to resolve
  a flake related to signin state.

TBR=nyquist@chromium.org
BUG=

Committed: https://crrev.com/a88f601af0666ad721b2d4e0e39bbd8a17470d41
Cr-Commit-Position: refs/heads/master@{#396728}
==========

[commit-bot: I haz the power, 2016-05-30 15:03:53]

Patchset 2 (id:??) landed as
https://crrev.com/a88f601af0666ad721b2d4e0e39bbd8a17470d41
Cr-Commit-Position: refs/heads/master@{#396728}