Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2875)

Unified Diff: chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/SyncTestBase.java

Issue 2025653002: [Sync] Clean up Android test code a bit, take 2. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix unused variable. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/SyncTestBase.java
diff --git a/chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/SyncTestBase.java b/chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/SyncTestBase.java
index ecc3f7ede5607d12ebaa1d402641273dbd604dc7..6dbe71b756343004604c3578ac8efeb1bbd6aa8f 100644
--- a/chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/SyncTestBase.java
+++ b/chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/SyncTestBase.java
@@ -127,7 +127,7 @@ public class SyncTestBase extends ChromeActivityTestCaseBase<ChromeActivity> {
FakeServerHelper.deleteFakeServer();
}
});
- SigninTestUtil.get().resetSigninState();
+ SigninTestUtil.resetSigninState();
super.tearDown();
}
@@ -139,12 +139,12 @@ public class SyncTestBase extends ChromeActivityTestCaseBase<ChromeActivity> {
}
protected Account setUpTestAccount() {
- Account account = SigninTestUtil.get().addAndSignInTestAccount();
- SyncTestUtil.verifySyncIsSignedOut();
+ Account account = SigninTestUtil.addTestAccount();
+ assertFalse(SyncTestUtil.isSyncRequested());
return account;
}
- protected Account setUpTestAccountAndSignInToSync() throws InterruptedException {
+ protected Account setUpTestAccountAndSignIn() throws InterruptedException {
Account account = setUpTestAccount();
signIn(account);
return account;
@@ -181,7 +181,9 @@ public class SyncTestBase extends ChromeActivityTestCaseBase<ChromeActivity> {
SigninManager.get(mContext).signIn(account, null, null);
}
});
- SyncTestUtil.verifySyncIsActiveForAccount(mContext, account);
+ SyncTestUtil.waitForSyncActive();
+ SyncTestUtil.triggerSyncAndWaitForCompletion();
+ assertEquals(account, SigninTestUtil.getCurrentAccount());
}
protected void signOut() throws InterruptedException {
@@ -198,7 +200,8 @@ public class SyncTestBase extends ChromeActivityTestCaseBase<ChromeActivity> {
}
});
assertTrue(s.tryAcquire(SyncTestUtil.TIMEOUT_MS, TimeUnit.MILLISECONDS));
- SyncTestUtil.verifySyncIsSignedOut();
+ assertNull(SigninTestUtil.getCurrentAccount());
+ assertFalse(SyncTestUtil.isSyncRequested());
}
protected void clearServerData() throws InterruptedException {

Powered by Google App Engine
This is Rietveld 408576698