ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.html - Issue 2025583002: MD WebUI: Improve tab focus behavior for toolbar search field

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.html

Issue 2025583002: MD WebUI: Improve tab focus behavior for toolbar search field (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Review comments Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ui/webui/resources/cr_elements/cr_search_field/cr_search_field_behavior.js ('k') | ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.js » ('j') | ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.html

diff --git a/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.html b/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.html

index c65855b1606af50a58edd2b9a740487ace383314..d64c02609bf2bec3a2c714a5e966973258c85fab 100644

--- a/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.html

+++ b/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.html

@@ -82,11 +82,12 @@

-webkit-margin-start: 18px;

}

</style>

- <paper-icon-button id="icon" icon="cr:search"

- title="[[label]]">

+ <paper-icon-button id="icon" icon="cr:search" title="[[label]]"

+ tabindex$="[[computeIconTabIndex_(narrow)]]">

</paper-icon-button>

- <paper-input-container on-search="onSearchTermSearch_"

- on-keydown="onSearchTermKeydown_" no-label-float>

+ <paper-input-container on-search="onSearchTermSearch"

+ on-keydown="onSearchTermKeydown" on-keypress="onSearchTermKeypress_"

+ no-label-float>

<label id="prompt" for="searchInput">[[label]]</label>

<input is="iron-input" id="searchInput" type="search"

on-blur="onInputBlur_" incremental></input>