ui/webui/resources/cr_elements/cr_search_field/cr_search_field_behavior.js - Issue 2025583002: MD WebUI: Improve tab focus behavior for toolbar search field

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/webui/resources/cr_elements/cr_search_field/cr_search_field_behavior.js

Issue 2025583002: MD WebUI: Improve tab focus behavior for toolbar search field (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Review comments Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ui/webui/resources/cr_elements/cr_search_field/cr_search_field.html ('k') | ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.html » ('j') | ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/webui/resources/cr_elements/cr_search_field/cr_search_field_behavior.js

diff --git a/ui/webui/resources/cr_elements/cr_search_field/cr_search_field_behavior.js b/ui/webui/resources/cr_elements/cr_search_field/cr_search_field_behavior.js

index b56c32974c1928bd89ac5110101c4336e434023f..3657f79f2600b74d83b7b4e4f754df3d87c44b32 100644

--- a/ui/webui/resources/cr_elements/cr_search_field/cr_search_field_behavior.js

+++ b/ui/webui/resources/cr_elements/cr_search_field/cr_search_field_behavior.js

@@ -73,15 +73,13 @@ var CrSearchFieldBehavior = {

this.$.searchInput.focus();

- /** @private */

- onSearchTermSearch_: function() {

+ onSearchTermSearch: function() {

this.hasSearchText = this.getValue() != '';

if (this.delegate_)

this.delegate_.onSearchTermSearch(this.getValue());

- /** @private */

- onSearchTermKeydown_: function(e) {

+ onSearchTermKeydown: function(e) {

if (e.key == 'Escape')

this.showingSearch = false;

@@ -95,7 +93,7 @@ var CrSearchFieldBehavior = {

this.setValue('');

this.$.searchInput.blur();

- this.onSearchTermSearch_();

+ this.onSearchTermSearch();

/** @private */