Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 2025573003: [turbofan] Remove eager frame state from call nodes. (Closed)

Created:
4 years, 6 months ago by Michael Starzinger
Modified:
4 years, 6 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_turbofan-checkpoint-1
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Remove eager frame state from call nodes. This removes the frame state input representing the before-state from nodes having the {JSCallFunction} or {JSCallConstruct} operator. These frame states can by now be found via checkpoints in the graph. R=bmeurer@chromium.org BUG=v8:5021 Committed: https://crrev.com/864b07e9ebc2288fc37032bc028b93292bc13647 Cr-Commit-Position: refs/heads/master@{#36669}

Patch Set 1 #

Patch Set 2 : Rebased and some fixes. #

Patch Set 3 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -55 lines) Patch
M src/compiler/js-call-reducer.cc View 8 chunks +2 lines, -12 lines 0 comments Download
M src/compiler/js-inlining.cc View 5 chunks +8 lines, -10 lines 0 comments Download
M src/compiler/js-typed-lowering.cc View 1 5 chunks +1 line, -13 lines 0 comments Download
M src/compiler/linkage.cc View 2 chunks +1 line, -1 line 0 comments Download
M src/compiler/node-properties.h View 2 chunks +5 lines, -1 line 0 comments Download
M src/compiler/node-properties.cc View 1 2 chunks +11 lines, -7 lines 0 comments Download
M src/compiler/operator-properties.cc View 1 2 chunks +4 lines, -6 lines 0 comments Download
M test/unittests/compiler/js-builtin-reducer-unittest.cc View 1 5 chunks +5 lines, -5 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (2 generated)
Michael Starzinger
4 years, 6 months ago (2016-05-30 13:00:02 UTC) #1
Michael Starzinger
PTAL. This should be ready for prime time now.
4 years, 6 months ago (2016-06-01 13:33:38 UTC) #2
Benedikt Meurer
LGTM.
4 years, 6 months ago (2016-06-01 18:29:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2025573003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2025573003/40001
4 years, 6 months ago (2016-06-02 08:00:32 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-06-02 08:02:37 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-02 08:04:39 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/864b07e9ebc2288fc37032bc028b93292bc13647
Cr-Commit-Position: refs/heads/master@{#36669}

Powered by Google App Engine
This is Rietveld 408576698