Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 2025523002: Revert of getComputedStyle should handle over-constrained properties. (patchset #7 id:100001 of htt… (Closed)

Created:
4 years, 6 months ago by rune
Modified:
4 years, 6 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

Revert of getComputedStyle should handle over-constrained properties. (patchset #7 id:100001 of https://codereview.chromium.org/1988813002/ ) Reason for revert: Other vendors didn't implement this yet. And work with the others to either get all to fix or to change the spec. BUG=614198 Original issue's description: > getComputedStyle should handle over-constrained properties. > > If neither 'left' nor 'right' is 'auto', the position is over-constrained, > and one of them has to be ignored. If 'direction' property of the > containing block is 'ltr', the value of 'left' wins and 'right' > becomes -'left'. If 'direction' of the containing block is 'rtl', > 'right' wins and 'left' is ignored. Detail is described by > https://www.w3.org/TR/2011/REC-CSS2-20110607/visuren.html#relative-positioning > > BUG=601118 > > Committed: https://crrev.com/c8291dea8bfa84ab9a3220fb9f57eb059e913a05 > Cr-Commit-Position: refs/heads/master@{#394780} TBR=mstensho@opera.com,alancutter@chromium.org,rune@opera.com,eae@chromium.org,timloh@chromium.org BUG=601118 Review-Url: https://codereview.chromium.org/2016913003 Cr-Commit-Position: refs/heads/master@{#396470} (cherry picked from commit 9835ebf3b20d95106a5541e44b297963e0136802) Committed: https://chromium.googlesource.com/chromium/src/+/608b46dc19395374c484a85ea3411460a67964c7

Patch Set 1 #

Messages

Total messages: 2 (1 generated)
rune
4 years, 6 months ago (2016-05-28 18:54:07 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
608b46dc19395374c484a85ea3411460a67964c7.

Powered by Google App Engine
This is Rietveld 408576698