Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 2016913003: Revert of getComputedStyle should handle over-constrained properties. (Closed)

Created:
4 years, 6 months ago by Deokjin Kim
Modified:
4 years, 6 months ago
CC:
chromium-reviews, blink-reviews-style_chromium.org, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of getComputedStyle should handle over-constrained properties. (patchset #7 id:100001 of https://codereview.chromium.org/1988813002/ ) Reason for revert: Other vendors didn't implement this yet. And work with the others to either get all to fix or to change the spec. BUG=614198 Original issue's description: > getComputedStyle should handle over-constrained properties. > > If neither 'left' nor 'right' is 'auto', the position is over-constrained, > and one of them has to be ignored. If 'direction' property of the > containing block is 'ltr', the value of 'left' wins and 'right' > becomes -'left'. If 'direction' of the containing block is 'rtl', > 'right' wins and 'left' is ignored. Detail is described by > https://www.w3.org/TR/2011/REC-CSS2-20110607/visuren.html#relative-positioning > > BUG=601118 > > Committed: https://crrev.com/c8291dea8bfa84ab9a3220fb9f57eb059e913a05 > Cr-Commit-Position: refs/heads/master@{#394780} TBR=mstensho@opera.com,alancutter@chromium.org,rune@opera.com,eae@chromium.org,timloh@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=601118 Committed: https://crrev.com/9835ebf3b20d95106a5541e44b297963e0136802 Cr-Commit-Position: refs/heads/master@{#396470}

Patch Set 1 #

Messages

Total messages: 13 (4 generated)
Deokjin Kim
Created Revert of getComputedStyle should handle over-constrained properties.
4 years, 6 months ago (2016-05-27 10:57:14 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2016913003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2016913003/1
4 years, 6 months ago (2016-05-27 10:57:25 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 6 months ago (2016-05-27 10:57:27 UTC) #4
Deokjin Kim
@rune, PTAL. Thank you in advance.
4 years, 6 months ago (2016-05-27 10:59:31 UTC) #5
rune
On 2016/05/27 10:59:31, Deokjin Kim wrote: > @rune, PTAL. Thank you in advance. lgtm
4 years, 6 months ago (2016-05-27 13:09:23 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2016913003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2016913003/1
4 years, 6 months ago (2016-05-27 13:23:06 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-27 15:22:36 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/9835ebf3b20d95106a5541e44b297963e0136802 Cr-Commit-Position: refs/heads/master@{#396470}
4 years, 6 months ago (2016-05-27 15:25:24 UTC) #12
eae
4 years, 6 months ago (2016-05-27 20:03:27 UTC) #13
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698