Refactoring data reduction proxy some methods to common

components/data_reduction_proxy/core/common/BUILD.gn

Index: components/data_reduction_proxy/core/common/BUILD.gn
diff --git a/components/data_reduction_proxy/core/common/BUILD.gn b/components/data_reduction_proxy/core/common/BUILD.gn
index c41cd174870244bcc12a479b6496d5b679ad4f3e..708f8211fa8cc75385700e679fac8b178e24c27a 100644
--- a/components/data_reduction_proxy/core/common/BUILD.gn
+++ b/components/data_reduction_proxy/core/common/BUILD.gn
@@ -4,22 +4,20 @@
 
 import("//chrome/version.gni")
 
 # Variables:
 #   deps: Extra dependencies.
 template("common_tmpl") {
   source_set(target_name) {
     sources = [
       "data_reduction_proxy_bypass_action_list.h",
       "data_reduction_proxy_bypass_type_list.h",
-      "data_reduction_proxy_client_config_parser.cc",
-      "data_reduction_proxy_client_config_parser.h",
       "data_reduction_proxy_config_values.h",
       "data_reduction_proxy_event_creator.cc",
       "data_reduction_proxy_event_creator.h",
       "data_reduction_proxy_event_storage_delegate.h",
       "data_reduction_proxy_event_store.cc",
       "data_reduction_proxy_event_store.h",
       "data_reduction_proxy_headers.cc",
       "data_reduction_proxy_headers.h",
       "data_reduction_proxy_params.cc",
       "data_reduction_proxy_params.h",
@@ -33,22 +31,25 @@ template("common_tmpl") {
       "lofi_ui_service.h",
     ]
 
     public_deps = [
       ":version_header",
     ]
     deps = [
       "//base",
       "//components/data_reduction_proxy/proto:data_reduction_proxy_proto",
       "//components/variations",
+      "//google_apis",
     ]
 
+    defines = [ "USE_GOOGLE_API_KEYS" ]

[tbansal1, 2016/05/27 23:01:58]

Two questions:
(1) data_reduction_proxy/core/browser/BUILD.gn has 
if (!is_ios) {
    defines += [ "USE_GOOGLE_API_KEYS_FOR_AUTH_KEY" ]
  }
Is that needed here?

(2) Should we update that file to remove dependencies and defines statements?

[RyanSturm, 2016/05/31 20:10:51]

1) not needed 2) still needed in core

I haven't moved all of the google_apis code from core to common, and the piece
that needs !is_ios is still in core.

+
     if (defined(invoker.deps)) {
       deps += invoker.deps
     }
   }
 }
 
 common_tmpl("common") {
   deps = [
     "//net",
     "//url",
@@ -74,24 +75,24 @@ source_set("test_support") {
     "//net",
     "//net:test_support",
     "//testing/gmock",
     "//testing/gtest",
   ]
 }
 
 source_set("unit_tests") {
   testonly = true
   sources = [
-    "data_reduction_proxy_client_config_parser_unittest.cc",
     "data_reduction_proxy_event_store_unittest.cc",
     "data_reduction_proxy_headers_unittest.cc",
     "data_reduction_proxy_params_unittest.cc",
+    "data_reduction_proxy_util_unittest.cc",
   ]
 
   deps = [
     ":common",
     ":test_support",
     "//base",
     "//base/test:test_support",
 
     # TODO this dependency seems wrong, but
     # data_reduction_proxy_event_store_unittest.cc includes a file from it.