Refactoring data reduction proxy some methods to common

components/data_reduction_proxy/core/common/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//chrome/version.gni")
 
 # Variables:
 #   deps: Extra dependencies.
 template("common_tmpl") {
   source_set(target_name) {
     sources = [
       "data_reduction_proxy_bypass_action_list.h",
       "data_reduction_proxy_bypass_type_list.h",
-      "data_reduction_proxy_client_config_parser.cc",
-      "data_reduction_proxy_client_config_parser.h",
       "data_reduction_proxy_config_values.h",
       "data_reduction_proxy_event_creator.cc",
       "data_reduction_proxy_event_creator.h",
       "data_reduction_proxy_event_storage_delegate.h",
       "data_reduction_proxy_event_store.cc",
       "data_reduction_proxy_event_store.h",
       "data_reduction_proxy_headers.cc",
       "data_reduction_proxy_headers.h",
       "data_reduction_proxy_params.cc",
       "data_reduction_proxy_params.h",
       "data_reduction_proxy_pref_names.cc",
       "data_reduction_proxy_pref_names.h",
       "data_reduction_proxy_switches.cc",
       "data_reduction_proxy_switches.h",
       "data_reduction_proxy_util.cc",
       "data_reduction_proxy_util.h",
       "lofi_decider.h",
       "lofi_ui_service.h",
     ]
 
     public_deps = [
       ":version_header",
     ]
     deps = [
       "//base",
       "//components/data_reduction_proxy/proto:data_reduction_proxy_proto",
       "//components/variations",
+      "//google_apis",
     ]
 
+    defines = [ "USE_GOOGLE_API_KEYS" ]

[tbansal1, 2016/05/27 23:01:58]

Two questions:
(1) data_reduction_proxy/core/browser/BUILD.gn has 
if (!is_ios) {
    defines += [ "USE_GOOGLE_API_KEYS_FOR_AUTH_KEY" ]
  }
Is that needed here?

(2) Should we update that file to remove dependencies and defines statements?

[RyanSturm, 2016/05/31 20:10:51]

1) not needed 2) still needed in core

I haven't moved all of the google_apis code from core to common, and the piece
that needs !is_ios is still in core.

+
     if (defined(invoker.deps)) {
       deps += invoker.deps
     }
   }
 }
 
 common_tmpl("common") {
   deps = [
     "//net",
     "//url",
@@ skipping 19 matching lines @@
     "//net",
     "//net:test_support",
     "//testing/gmock",
     "//testing/gtest",
   ]
 }
 
 source_set("unit_tests") {
   testonly = true
   sources = [
-    "data_reduction_proxy_client_config_parser_unittest.cc",
     "data_reduction_proxy_event_store_unittest.cc",
     "data_reduction_proxy_headers_unittest.cc",
     "data_reduction_proxy_params_unittest.cc",
+    "data_reduction_proxy_util_unittest.cc",
   ]
 
   deps = [
     ":common",
     ":test_support",
     "//base",
     "//base/test:test_support",
 
     # TODO this dependency seems wrong, but
     # data_reduction_proxy_event_store_unittest.cc includes a file from it.
     "//components/data_reduction_proxy/core/browser",
     "//components/data_reduction_proxy/proto:data_reduction_proxy_proto",
     "//components/variations",
     "//net:test_support",
     "//testing/gtest",
   ]
 }
 
 process_version("version_header") {
   template_file = "version.h.in"
   output = "$target_gen_dir/version.h"
   extra_args = [
     "-e",
     "VERSION_FULL=\"%s.%s.%s.%s\" % (MAJOR,MINOR,BUILD,PATCH)",
   ]
 }