Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2025373002: Add error messages for canvas creation failures (Closed)

Created:
4 years, 6 months ago by Xianzhu
Modified:
4 years, 6 months ago
CC:
chromium-reviews, mlamouri+watch-test-runner_chromium.org, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add error messages for canvas creation failures BUG=591500 TBR=tommyw@chromium.org,rmistry@chromium.org R=forshaw@chromium.org Committed: https://crrev.com/726d29ca0ef67aff29b78d03fa105a9eb90f404d Cr-Commit-Position: refs/heads/master@{#397441}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -3 lines) Patch
M components/test_runner/pixel_dump.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M skia/ext/bitmap_platform_device_win.cc View 1 chunk +9 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Xianzhu
4 years, 6 months ago (2016-06-01 18:08:12 UTC) #2
Xianzhu
4 years, 6 months ago (2016-06-01 18:12:00 UTC) #3
Xianzhu
On 2016/06/01 18:12:00, Xianzhu wrote: ping...
4 years, 6 months ago (2016-06-02 16:10:46 UTC) #4
forshaw
On 2016/06/02 16:10:46, Xianzhu wrote: > On 2016/06/01 18:12:00, Xianzhu wrote: > > ping... lgtm
4 years, 6 months ago (2016-06-02 16:31:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2025373002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2025373002/1
4 years, 6 months ago (2016-06-02 16:33:07 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-02 16:37:57 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-02 16:39:31 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/726d29ca0ef67aff29b78d03fa105a9eb90f404d
Cr-Commit-Position: refs/heads/master@{#397441}

Powered by Google App Engine
This is Rietveld 408576698