Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Unified Diff: components/test_runner/pixel_dump.cc

Issue 2025373002: Add error messages for canvas creation failures (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | skia/ext/bitmap_platform_device_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/test_runner/pixel_dump.cc
diff --git a/components/test_runner/pixel_dump.cc b/components/test_runner/pixel_dump.cc
index 5bebb1ecbba57898dafac658a242e2dbdfc5e53d..fc859d782c521dfe0b3f6e5ad5301692ce8874ad 100644
--- a/components/test_runner/pixel_dump.cc
+++ b/components/test_runner/pixel_dump.cc
@@ -98,6 +98,8 @@ void CapturePixelsForPrinting(std::unique_ptr<PixelsDumpRequest> dump_request) {
sk_sp<SkCanvas> canvas(skia::TryCreateBitmapCanvas(
page_size_in_pixels.width, totalHeight, is_opaque));
if (!canvas) {
+ LOG(ERROR) << "Failed to create canvas width="
+ << page_size_in_pixels.width << " height=" << totalHeight;
dump_request->callback.Run(SkBitmap());
return;
}
« no previous file with comments | « no previous file | skia/ext/bitmap_platform_device_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698