Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 2025303002: Extensions: Add test for granting nuisance and implied permissions on update (Closed)

Created:
4 years, 6 months ago by Marc Treib
Modified:
4 years, 6 months ago
Reviewers:
Devlin
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Extensions: Add test for granting nuisance and implied permissions on update This is the test that should have accompanied https://codereview.chromium.org/1995533002 BUG=603822 Committed: https://crrev.com/fef128daf132927b488fea58466ab834ccf7e1b7 Cr-Commit-Position: refs/heads/master@{#397344}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -0 lines) Patch
M chrome/browser/extensions/extension_service_unittest.cc View 1 chunk +88 lines, -1 line 0 comments Download
A + chrome/test/data/extensions/permissions/update.pem View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/test/data/extensions/permissions/update_1/manifest.json View 1 chunk +6 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/permissions/update_2/manifest.json View 1 chunk +6 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/permissions/update_3/manifest.json View 1 chunk +6 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/permissions/update_4/manifest.json View 1 chunk +6 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (5 generated)
Marc Treib
Better late than never :) PTAL!
4 years, 6 months ago (2016-06-01 14:33:19 UTC) #3
Devlin
lgtm, thanks!
4 years, 6 months ago (2016-06-01 17:09:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2025303002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2025303002/1
4 years, 6 months ago (2016-06-02 07:31:52 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-02 09:15:05 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-06-02 09:16:48 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fef128daf132927b488fea58466ab834ccf7e1b7
Cr-Commit-Position: refs/heads/master@{#397344}

Powered by Google App Engine
This is Rietveld 408576698