Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(666)

Issue 1995533002: Extensions: Grant nuisance and already-implied permissions on update (Closed)

Created:
4 years, 7 months ago by Marc Treib
Modified:
4 years, 7 months ago
Reviewers:
Devlin
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Extensions: Grant nuisance and already-implied permissions on update BUG=603822 Committed: https://crrev.com/2c20f944e2e1d615eb57d0520e25308d82d0516d Cr-Commit-Position: refs/heads/master@{#394511}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M chrome/browser/extensions/extension_service.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Marc Treib
PTAL! This should *really* have a test. I thought it'd be easy to copy-paste and ...
4 years, 7 months ago (2016-05-18 13:33:42 UTC) #3
Devlin
lgtm, but please, please, *please* do add tests for this ASAP.
4 years, 7 months ago (2016-05-18 17:18:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1995533002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1995533002/1
4 years, 7 months ago (2016-05-18 19:03:04 UTC) #6
Marc Treib
On 2016/05/18 17:18:13, Devlin wrote: > lgtm, but please, please, *please* do add tests for ...
4 years, 7 months ago (2016-05-18 19:03:30 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-18 19:50:39 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-18 19:53:03 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2c20f944e2e1d615eb57d0520e25308d82d0516d
Cr-Commit-Position: refs/heads/master@{#394511}

Powered by Google App Engine
This is Rietveld 408576698