Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 2025233002: Temorarily comment out NOTREACHED in task manager. (Closed)

Created:
4 years, 6 months ago by Anand Mistry (off Chromium)
Modified:
4 years, 6 months ago
Reviewers:
afakhry, ncarter (slow)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Temorarily comment out NOTREACHED in task manager. This condition is reached because of how Mojo interacts with child process setup. While this is being fixed, comment out the check to avoid test flakes on the bots. BUG=611067 Committed: https://crrev.com/c7a521f9d0b1f589b9dafcfdac381d10be9a9258 Cr-Commit-Position: refs/heads/master@{#397296}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M chrome/browser/task_management/providers/child_process_task_provider.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 18 (8 generated)
Anand Mistry (off Chromium)
afakhry: I know you're not a fan of this, but the the fix isn't easy ...
4 years, 6 months ago (2016-06-01 04:40:51 UTC) #2
afakhry
I don't mind commenting it out if that's what you and +Nick have agreed on, ...
4 years, 6 months ago (2016-06-01 16:24:45 UTC) #4
ncarter (slow)
lgtm
4 years, 6 months ago (2016-06-01 21:15:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2025233002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2025233002/1
4 years, 6 months ago (2016-06-01 21:16:41 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/239368)
4 years, 6 months ago (2016-06-02 02:10:38 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2025233002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2025233002/1
4 years, 6 months ago (2016-06-02 03:51:36 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/239585)
4 years, 6 months ago (2016-06-02 04:29:33 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2025233002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2025233002/1
4 years, 6 months ago (2016-06-02 04:41:33 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-02 05:45:49 UTC) #16
commit-bot: I haz the power
4 years, 6 months ago (2016-06-02 05:47:26 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c7a521f9d0b1f589b9dafcfdac381d10be9a9258
Cr-Commit-Position: refs/heads/master@{#397296}

Powered by Google App Engine
This is Rietveld 408576698