|
|
Chromium Code Reviews|
Created:
4 years, 6 months ago by Anand Mistry (off Chromium) Modified:
4 years, 6 months ago CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionTemorarily comment out NOTREACHED in task manager.
This condition is reached because of how Mojo interacts with child
process setup. While this is being fixed, comment out the check to avoid
test flakes on the bots.
BUG=611067
Committed: https://crrev.com/c7a521f9d0b1f589b9dafcfdac381d10be9a9258
Cr-Commit-Position: refs/heads/master@{#397296}
Patch Set 1 #
Messages
Total messages: 18 (8 generated)
amistry@chromium.org changed reviewers: + afakhry@chromium.org
afakhry: I know you're not a fan of this, but the the fix isn't easy and the flakes are causing CQ submit issues.
afakhry@chromium.org changed reviewers: + nick@chromium.org
I don't mind commenting it out if that's what you and +Nick have agreed on, in the other CL.
lgtm
The CQ bit was checked by nick@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2025233002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2025233002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by amistry@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2025233002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2025233002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by amistry@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2025233002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2025233002/1
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Temorarily comment out NOTREACHED in task manager. This condition is reached because of how Mojo interacts with child process setup. While this is being fixed, comment out the check to avoid test flakes on the bots. BUG=611067 ========== to ========== Temorarily comment out NOTREACHED in task manager. This condition is reached because of how Mojo interacts with child process setup. While this is being fixed, comment out the check to avoid test flakes on the bots. BUG=611067 Committed: https://crrev.com/c7a521f9d0b1f589b9dafcfdac381d10be9a9258 Cr-Commit-Position: refs/heads/master@{#397296} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/c7a521f9d0b1f589b9dafcfdac381d10be9a9258 Cr-Commit-Position: refs/heads/master@{#397296} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
