Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2754)

Unified Diff: chrome/browser/task_management/providers/child_process_task_provider.cc

Issue 2025233002: Temorarily comment out NOTREACHED in task manager. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/task_management/providers/child_process_task_provider.cc
diff --git a/chrome/browser/task_management/providers/child_process_task_provider.cc b/chrome/browser/task_management/providers/child_process_task_provider.cc
index 884310b9359583dbd28f27315ca697ad2f6d1539..3eee3d393362a54e4901ce91226e904d02240769 100644
--- a/chrome/browser/task_management/providers/child_process_task_provider.cc
+++ b/chrome/browser/task_management/providers/child_process_task_provider.cc
@@ -144,7 +144,10 @@ void ChildProcessTaskProvider::DeleteTask(base::ProcessHandle handle) {
// processes and are notified (on the UI thread) that the collection is
// completed at |ChildProcessDataCollected()|.
if (itr == tasks_by_handle_.end()) {
- NOTREACHED();
+ // BUG(crbug.com/611067): Temporarily removing due to test flakes. The
+ // reason why this happens is well understood (see bug), but there's no
+ // quick and easy fix.
+ // NOTREACHED();
return;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698