Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 202523003: Declare dependency from ppapi_proxy targets on blink API (Closed)

Created:
6 years, 9 months ago by jamesr
Modified:
6 years, 9 months ago
Reviewers:
bbudge
CC:
chromium-reviews
Visibility:
Public.

Description

Declare dependencie from ppapi_proxy targets on blink API websocket_resource.cc in ppapi_proxy uses blink's WebSocket.h, but does not declare a dependency. We'd like to have all such dependencies declared explicitly so we can export settings like include_dirs from the blink public API to make the includes within the API more rational. This adds a dependency on blink_headers (since this does not depend on any symbols exported from blink) so that it can be configured correctly. BUG=350097

Patch Set 1 #

Total comments: 1

Patch Set 2 : with TODO #

Patch Set 3 : add TODO to both refs in gypi #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M ppapi/ppapi_internal.gyp View 1 2 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
jamesr
bbudge@ - please take a look, missed this target in the last round.
6 years, 9 months ago (2014-03-17 22:05:19 UTC) #1
bbudge
LGTM please add a TODO for me to fix this. https://codereview.chromium.org/202523003/diff/1/ppapi/ppapi_internal.gyp File ppapi/ppapi_internal.gyp (right): https://codereview.chromium.org/202523003/diff/1/ppapi/ppapi_internal.gyp#newcode131 ...
6 years, 9 months ago (2014-03-17 22:17:40 UTC) #2
jamesr
On 2014/03/17 22:17:40, bbudge wrote: > LGTM please add a TODO for me to fix ...
6 years, 9 months ago (2014-03-17 22:29:09 UTC) #3
jamesr
The CQ bit was checked by jamesr@chromium.org
6 years, 9 months ago (2014-03-17 22:40:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/202523003/30001
6 years, 9 months ago (2014-03-17 22:48:05 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-18 00:37:29 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 9 months ago (2014-03-18 00:37:30 UTC) #7
bbudge
On 2014/03/17 22:29:09, jamesr wrote: > On 2014/03/17 22:17:40, bbudge wrote: > > LGTM please ...
6 years, 9 months ago (2014-03-18 17:24:57 UTC) #8
jamesr
That's even better. Closing.
6 years, 9 months ago (2014-03-18 18:07:27 UTC) #9
jamesr
6 years, 9 months ago (2014-03-18 18:07:28 UTC) #10
Message was sent while issue was closed.
That's even better. Closing.

Powered by Google App Engine
This is Rietveld 408576698