Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Unified Diff: ppapi/ppapi_internal.gyp

Issue 202523003: Declare dependency from ppapi_proxy targets on blink API (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: add TODO to both refs in gypi Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/ppapi_internal.gyp
diff --git a/ppapi/ppapi_internal.gyp b/ppapi/ppapi_internal.gyp
index 989a5915f63d534abb3ff9a785a5915a9ced7860..d0eff9062b5df267623cdc9a9b8354a8263f5ba1 100644
--- a/ppapi/ppapi_internal.gyp
+++ b/ppapi/ppapi_internal.gyp
@@ -127,6 +127,10 @@
'../skia/skia.gyp:skia',
'../third_party/icu/icu.gyp:icuuc',
'../third_party/icu/icu.gyp:icui18n',
+ # websocket_resource.cc uses enums from blink's WebSocket.h
+ # TODO(bbudge): Figure out a good place to put a conversion utility
+ # instead of using the Blink enum values.
+ '../third_party/WebKit/public/blink_headers.gyp:blink_headers',
'../ui/surface/surface.gyp:surface',
'ppapi.gyp:ppapi_c',
'ppapi_shared',
@@ -175,6 +179,10 @@
'../skia/skia.gyp:skia',
'../third_party/icu/icu.gyp:icuuc',
'../third_party/icu/icu.gyp:icui18n',
+ # websocket_resource.cc uses enums from blink's WebSocket.h
+ # TODO(bbudge): Figure out a good place to put a conversion utility
+ # instead of using the Blink enum values.
+ '../third_party/WebKit/public/blink_headers.gyp:blink_headers',
'../ui/surface/surface.gyp:surface',
'ppapi.gyp:ppapi_c',
'ppapi_shared',
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698