third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium/fetch-request-with-gc.html - Issue 2025143003: [Fetch API] Request's JS wrapper should be kept alive in FetchEvent

Unified Diff: third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium/fetch-request-with-gc.html

Issue 2025143003: [Fetch API] Request's JS wrapper should be kept alive in FetchEvent (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium/resources/fetch-request-with-gc.js » ('j') | third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium/resources/fetch-request-with-gc.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium/fetch-request-with-gc.html

diff --git a/third_party/WebKit/LayoutTests/http/tests/serviceworker/fetch-cors-xhr.html b/third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium/fetch-request-with-gc.html

similarity index 71%

copy from third_party/WebKit/LayoutTests/http/tests/serviceworker/fetch-cors-xhr.html

copy to third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium/fetch-request-with-gc.html

index ee22c7fab5a5682a2087b429adf2c9e141275400..589a890abfad114b5de7fe76be92f90519a23f65 100644

--- a/third_party/WebKit/LayoutTests/http/tests/serviceworker/fetch-cors-xhr.html

+++ b/third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium/fetch-request-with-gc.html

@@ -1,14 +1,14 @@

<!DOCTYPE html>

falken 2016/06/02 08:36:31 can you put a comment about why this is in chromiu

yhirano 2016/06/02 10:10:11 Done.

<title>Service Worker: CORS XHR of fetch()</title>

falken 2016/06/02 08:36:31 update title

yhirano 2016/06/02 10:10:11 Done.

-<script src="../resources/testharness.js"></script>

-<script src="../resources/testharnessreport.js"></script>

-<script src="../resources/get-host-info.js?pipe=sub"></script>

-<script src="resources/test-helpers.js"></script>

+<script src="../..//resources/testharness.js"></script>

+<script src="../../resources/testharnessreport.js"></script>

+<script src="../../resources/get-host-info.js?pipe=sub"></script>

+<script src="../resources/test-helpers.js"></script>

<body>

async_test(function(t) {

- var SCOPE = 'resources/fetch-cors-xhr-iframe.html';

- var SCRIPT = 'resources/fetch-rewrite-worker.js';

+ var SCOPE = 'resources/fetch-request-with-gc-iframe.html';

+ var SCRIPT = 'resources/fetch-request-with-gc.js';

var host_info = get_host_info();

@@ -33,6 +33,7 @@ async_test(function(t) {

});

})

.catch(unreached_rejection(t));

- }, 'Verify CORS XHR of fetch() in a Service Worker');

+ }, 'Calling gc and delaying calling fetch in onFetch should not lead to crash');

</script>

</body>

falken 2016/06/02 08:36:31 :~)

yhirano 2016/06/02 10:10:11 Done.