third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium/fetch-request-with-gc.html - Issue 2025143003: [Fetch API] Request's JS wrapper should be kept alive in FetchEvent

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium/fetch-request-with-gc.html

Issue 2025143003: [Fetch API] Request's JS wrapper should be kept alive in FetchEvent (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium/resources/fetch-request-with-gc.js » ('j') | third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium/resources/fetch-request-with-gc.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>
	falken 2016/06/02 08:36:31 can you put a comment about why this is in chromiu can you put a comment about why this is in chromium/ (something like: this tests that Request is still usable after garbage collection, which is an implementation detail) yhirano 2016/06/02 10:10:11 Done. Show quoted text On 2016/06/02 08:36:31, falken wrote: > can you put a comment about why this is in chromium/ > (something like: this tests that Request is still usable after garbage > collection, which is an implementation detail) Done.
2 <title>Service Worker: CORS XHR of fetch()</title>	2 <title>Service Worker: CORS XHR of fetch()</title>
	falken 2016/06/02 08:36:31 update title update title yhirano 2016/06/02 10:10:11 Done. Show quoted text On 2016/06/02 08:36:31, falken wrote: > update title Done.
3 <script src="../resources/testharness.js"></script>	3 <script src="../..//resources/testharness.js"></script>

4 <script src="../resources/testharnessreport.js"></script>	4 <script src="../../resources/testharnessreport.js"></script>

5 <script src="../resources/get-host-info.js?pipe=sub"></script>	5 <script src="../../resources/get-host-info.js?pipe=sub"></script>

6 <script src="resources/test-helpers.js"></script>	6 <script src="../resources/test-helpers.js"></script>

7 <body>	7 <body>

8 <script>	8 <script>

9 async_test(function(t) {	9 async_test(function(t) {

10 var SCOPE = 'resources/fetch-cors-xhr-iframe.html';	10 var SCOPE = 'resources/fetch-request-with-gc-iframe.html';

11 var SCRIPT = 'resources/fetch-rewrite-worker.js';	11 var SCRIPT = 'resources/fetch-request-with-gc.js';

12 var host_info = get_host_info();	12 var host_info = get_host_info();

13	13

14 login(t, host_info.HTTP_ORIGIN, host_info.HTTP_REMOTE_ORIGIN)	14 login(t, host_info.HTTP_ORIGIN, host_info.HTTP_REMOTE_ORIGIN)

15 .then(function() {	15 .then(function() {

16 return service_worker_unregister_and_register(t, SCRIPT, SCOPE);	16 return service_worker_unregister_and_register(t, SCRIPT, SCOPE);

17 })	17 })

18 .then(function(registration) {	18 .then(function(registration) {

19 return wait_for_state(t, registration.installing, 'activated');	19 return wait_for_state(t, registration.installing, 'activated');

20 })	20 })

21 .then(function() { return with_iframe(SCOPE); })	21 .then(function() { return with_iframe(SCOPE); })

22 .then(function(frame) {	22 .then(function(frame) {

23 return new Promise(function(resolve, reject) {	23 return new Promise(function(resolve, reject) {

24 var channel = new MessageChannel();	24 var channel = new MessageChannel();

25 channel.port1.onmessage = t.step_func(function(e) {	25 channel.port1.onmessage = t.step_func(function(e) {

26 assert_equals(e.data.results, 'finish');	26 assert_equals(e.data.results, 'finish');

27 frame.remove();	27 frame.remove();

28 service_worker_unregister_and_done(t, SCOPE);	28 service_worker_unregister_and_done(t, SCOPE);

29 });	29 });

30 frame.contentWindow.postMessage({},	30 frame.contentWindow.postMessage({},

31 host_info['HTTP_ORIGIN'],	31 host_info['HTTP_ORIGIN'],

32 [channel.port2]);	32 [channel.port2]);

33 });	33 });

34 })	34 })

35 .catch(unreached_rejection(t));	35 .catch(unreached_rejection(t));

36 }, 'Verify CORS XHR of fetch() in a Service Worker');	36 }, 'Calling gc and delaying calling fetch in onFetch should not lead to crash' );

37 </script>	37 </script>

38 </body>	38 </body>

	39 ~
	falken 2016/06/02 08:36:31 :~) :~) yhirano 2016/06/02 10:10:11 Done. Show quoted text On 2016/06/02 08:36:31, falken wrote: > :~) Done.
OLD	NEW