ExtensionFunction: don't pass ownership of base::Value by raw pointer.

extensions/browser/extension_function.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef EXTENSIONS_BROWSER_EXTENSION_FUNCTION_H_
 #define EXTENSIONS_BROWSER_EXTENSION_FUNCTION_H_
 
 #include <stddef.h>
 
 #include <list>
@@ skipping 277 matching lines @@
     return source_process_id_;
   }
 
  protected:
   friend struct ExtensionFunctionDeleteTraits;
 
   // ResponseValues.
   //
   // Success, no arguments to pass to caller.
   ResponseValue NoArguments();
-  // Success, a single argument |arg| to pass to caller. TAKES OWNERSHIP - a
-  // raw pointer for convenience, since callers usually construct the argument
-  // to this by hand.
-  ResponseValue OneArgument(base::Value* arg);
   // Success, a single argument |arg| to pass to caller.
   ResponseValue OneArgument(std::unique_ptr<base::Value> arg);
-  // Success, two arguments |arg1| and |arg2| to pass to caller. TAKES
-  // OWNERSHIP - raw pointers for convenience, since callers usually construct
-  // the argument to this by hand. Note that use of this function may imply you
+  // Success, two arguments |arg1| and |arg2| to pass to caller.
+  // Note that use of this function may imply you
   // should be using the generated Result struct and ArgumentList.
-  ResponseValue TwoArguments(base::Value* arg1, base::Value* arg2);
-  // Success, a list of arguments |results| to pass to caller. TAKES OWNERSHIP
+  ResponseValue TwoArguments(std::unique_ptr<base::Value> arg1,
+                             std::unique_ptr<base::Value> arg2);
+  // Success, a list of arguments |results| to pass to caller.
   // - a std::unique_ptr<> for convenience, since callers usually get this from
-  // the
-  // result of a Create(...) call on the generated Results struct, for example,
-  // alarms::Get::Results::Create(alarm).
+  //   the result of a Create(...) call on the generated Results struct. For
+  //   example, alarms::Get::Results::Create(alarm).
   ResponseValue ArgumentList(std::unique_ptr<base::ListValue> results);
   // Error. chrome.runtime.lastError.message will be set to |error|.
   ResponseValue Error(const std::string& error);
   // Error with formatting. Args are processed using
   // ErrorUtils::FormatErrorMessage, that is, each occurence of * is replaced
   // by the corresponding |s*|:
   // Error("Error in *: *", "foo", "bar") <--> Error("Error in foo: bar").
   ResponseValue Error(const std::string& format, const std::string& s1);
   ResponseValue Error(const std::string& format,
                       const std::string& s1,
                       const std::string& s2);
   ResponseValue Error(const std::string& format,
                       const std::string& s1,
                       const std::string& s2,
                       const std::string& s3);
-  // Error with a list of arguments |args| to pass to caller. TAKES OWNERSHIP.
+  // Error with a list of arguments |args| to pass to caller.
   // Using this ResponseValue indicates something is wrong with the API.
   // It shouldn't be possible to have both an error *and* some arguments.
   // Some legacy APIs do rely on it though, like webstorePrivate.
   ResponseValue ErrorWithArguments(std::unique_ptr<base::ListValue> args,
                                    const std::string& error);
   // Bad message. A ResponseValue equivalent to EXTENSION_FUNCTION_VALIDATE(),
   // so this will actually kill the renderer and not respond at all.
   ResponseValue BadMessage();
 
   // ResponseActions.
@@ skipping 342 matching lines @@
  private:
   // If you're hitting a compile error here due to "final" - great! You're
   // doing the right thing, you just need to extend IOThreadExtensionFunction
   // instead of SyncIOExtensionFunction.
   ResponseAction Run() final;
 
   DISALLOW_COPY_AND_ASSIGN(SyncIOThreadExtensionFunction);
 };
 
 #endif  // EXTENSIONS_BROWSER_EXTENSION_FUNCTION_H_