ExtensionFunction: don't pass ownership of base::Value by raw pointer.

extensions/browser/extension_function.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/browser/extension_function.h"
 
 #include <utility>
 
 #include "base/logging.h"
 #include "base/macros.h"
@@ skipping 273 matching lines @@
 bool ExtensionFunction::user_gesture() const {
   return user_gesture_ || UserGestureForTests::GetInstance()->HaveGesture();
 }
 
 ExtensionFunction::ResponseValue ExtensionFunction::NoArguments() {
   return ResponseValue(new ArgumentListResponseValue(
       name(), "NoArguments", this, base::WrapUnique(new base::ListValue())));
 }
 
 ExtensionFunction::ResponseValue ExtensionFunction::OneArgument(
-    base::Value* arg) {
+    std::unique_ptr<base::Value> arg) {
   std::unique_ptr<base::ListValue> args(new base::ListValue());
-  args->Append(arg);
+  args->Append(std::move(arg));
   return ResponseValue(new ArgumentListResponseValue(name(), "OneArgument",
                                                      this, std::move(args)));
 }
 
-ExtensionFunction::ResponseValue ExtensionFunction::OneArgument(
-    std::unique_ptr<base::Value> arg) {
-  return OneArgument(arg.release());
-}
-
 ExtensionFunction::ResponseValue ExtensionFunction::TwoArguments(
-    base::Value* arg1,
-    base::Value* arg2) {
+    std::unique_ptr<base::Value> arg1,
+    std::unique_ptr<base::Value> arg2) {
   std::unique_ptr<base::ListValue> args(new base::ListValue());
-  args->Append(arg1);
-  args->Append(arg2);
+  args->Append(std::move(arg1));
+  args->Append(std::move(arg2));
   return ResponseValue(new ArgumentListResponseValue(name(), "TwoArguments",
                                                      this, std::move(args)));
 }
 
 ExtensionFunction::ResponseValue ExtensionFunction::ArgumentList(
     std::unique_ptr<base::ListValue> args) {
   return ResponseValue(new ArgumentListResponseValue(name(), "ArgumentList",
                                                      this, std::move(args)));
 }
 
@@ skipping 250 matching lines @@
 ExtensionFunction::ResponseAction SyncIOThreadExtensionFunction::Run() {
   return RespondNow(RunSync() ? ArgumentList(std::move(results_))
                               : Error(error_));
 }
 
 // static
 bool SyncIOThreadExtensionFunction::ValidationFailure(
     SyncIOThreadExtensionFunction* function) {
   return false;
 }