Issue 2025093002: Refactor to simplify how layerType is stored on PaintLayers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2025093002: Refactor to simplify how layerType is stored on PaintLayers. (Closed)

Created:
4 years, 6 months ago by chrishtr

Modified:
4 years, 6 months ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2743

Target Ref:
refs/pending/branch-heads/2743

Project:
chromium

Visibility:
Public.

More Reviews

Description

Refactor to simplify how layerType is stored on PaintLayers. Instead of caching it on the PaintLayer, delegate to the LayoutBoxModelObject to compute it on demand. Also remove a useless setter for it. BUG=610906 Review-Url: https://codereview.chromium.org/2002153007 Cr-Commit-Position: refs/heads/master@{#396096} (cherry picked from commit 4a1368f4a8cbc725bd4be8e216fc9f717f7b9f8d)

Patch Set 1 #

Created: 4 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -17 lines)			Patch
M	third_party/WebKit/Source/core/layout/LayoutBoxModelObject.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp	View	3 chunks	+3 lines, -7 lines	0 comments	Download
M	third_party/WebKit/Source/core/paint/PaintLayer.h	View	3 chunks	+1 line, -5 lines	0 comments	Download
M	third_party/WebKit/Source/core/paint/PaintLayer.cpp	View	2 chunks	+3 lines, -4 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

chrishtr

4 years, 6 months ago (2016-05-31 20:14:50 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) to pending queue manually as
3b3bbeee7b3c0d1de15d7854b58cc474b7204478.

Expand Messages | Collapse Messages