Refactor to simplify how layerType is stored on PaintLayers.

Refactor to simplify how layerType is stored on PaintLayers.

Instead of caching it on the PaintLayer, delegate to the LayoutBoxModelObject
to compute it on demand. Also remove a useless setter for it.

BUG=610906
Committed: https://crrev.com/4a1368f4a8cbc725bd4be8e216fc9f717f7b9f8d
Cr-Commit-Position: refs/heads/master@{#396096}

[chrishtr, 2016-05-25 22:39:12]

Description was changed from

==========
none

BUG=
==========

to

==========
Refactor to simplify how layerType is stored on PaintLayers.

Instead of caching it on the PaintLayer, delegate to the LayoutBoxModelObject
to compute it on demand. Also remove a useless setter for it.

BUG=610906
==========

[chrishtr, 2016-05-25 23:23:42]

chrishtr@chromium.org changed reviewers:
+ pdr@chromium.org

[pdr., 2016-05-26 00:11:20]

Nice cleanup

https://codereview.chromium.org/2002153007/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/paint/PaintLayer.cpp (right):

https://codereview.chromium.org/2002153007/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/paint/PaintLayer.cpp:138:
PaintLayer::PaintLayer(LayoutBoxModelObject* layoutObject, PaintLayerType type)
With this gone, can you remove the PaintLayerType argument too? It's plumbed
through a couple calls.

[chrishtr, 2016-05-26 00:37:05]

https://codereview.chromium.org/2002153007/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/paint/PaintLayer.cpp (right):

https://codereview.chromium.org/2002153007/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/paint/PaintLayer.cpp:138:
PaintLayer::PaintLayer(LayoutBoxModelObject* layoutObject, PaintLayerType type)
On 2016/05/26 at 00:11:19, pdr. wrote:
> With this gone, can you remove the PaintLayerType argument too? It's plumbed
through a couple calls.

Done.

[pdr., 2016-05-26 00:37:35]

On 2016/05/26 at 00:37:05, chrishtr wrote:
>
https://codereview.chromium.org/2002153007/diff/1/third_party/WebKit/Source/c...
> File third_party/WebKit/Source/core/paint/PaintLayer.cpp (right):
> 
>
https://codereview.chromium.org/2002153007/diff/1/third_party/WebKit/Source/c...
> third_party/WebKit/Source/core/paint/PaintLayer.cpp:138:
PaintLayer::PaintLayer(LayoutBoxModelObject* layoutObject, PaintLayerType type)
> On 2016/05/26 at 00:11:19, pdr. wrote:
> > With this gone, can you remove the PaintLayerType argument too? It's plumbed
through a couple calls.
> 
> Done.

LGTM

[pdr., 2016-05-26 00:37:43]

The CQ bit was checked by pdr@chromium.org

[commit-bot: I haz the power, 2016-05-26 00:38:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2002153007/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2002153007/20001

[commit-bot: I haz the power, 2016-05-26 03:21:13]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-26 03:22:59]

Description was changed from

==========
Refactor to simplify how layerType is stored on PaintLayers.

Instead of caching it on the PaintLayer, delegate to the LayoutBoxModelObject
to compute it on demand. Also remove a useless setter for it.

BUG=610906
==========

to

==========
Refactor to simplify how layerType is stored on PaintLayers.

Instead of caching it on the PaintLayer, delegate to the LayoutBoxModelObject
to compute it on demand. Also remove a useless setter for it.

BUG=610906

Committed: https://crrev.com/4a1368f4a8cbc725bd4be8e216fc9f717f7b9f8d
Cr-Commit-Position: refs/heads/master@{#396096}
==========

[commit-bot: I haz the power, 2016-05-26 03:23:00]

Patchset 2 (id:??) landed as
https://crrev.com/4a1368f4a8cbc725bd4be8e216fc9f717f7b9f8d
Cr-Commit-Position: refs/heads/master@{#396096}