Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 2025013003: Adding scoped_nsobject for MockCBService (Closed)

Created:
4 years, 6 months ago by jlebel
Modified:
4 years, 6 months ago
CC:
chromium-reviews, ortuno+watch_chromium.org, scheib+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adding scoped_nsobject for MockCBService BUG=None Committed: https://crrev.com/6986d3bf95621f4eb8cd72e0ab823f7b1254fb97 Cr-Commit-Position: refs/heads/master@{#397612}

Patch Set 1 #

Patch Set 2 : Removing synthesize #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -8 lines) Patch
M device/bluetooth/test/mock_bluetooth_cbservice_mac.mm View 1 3 chunks +6 lines, -8 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
jlebel
Hello Giovanni, Can you review this small patch to cleanup retain/release? Thanks,
4 years, 6 months ago (2016-06-01 03:20:49 UTC) #3
jlebel
Hello Giovanni, Can you review this small patch to cleanup retain/release? Thanks,
4 years, 6 months ago (2016-06-01 03:20:49 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2025013003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2025013003/1
4 years, 6 months ago (2016-06-01 03:25:50 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/212030)
4 years, 6 months ago (2016-06-01 03:41:21 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2025013003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2025013003/20001
4 years, 6 months ago (2016-06-01 03:46:42 UTC) #10
ortuno
lgtm
4 years, 6 months ago (2016-06-01 04:10:19 UTC) #11
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-01 05:00:01 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2025013003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2025013003/20001
4 years, 6 months ago (2016-06-02 22:12:16 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-03 03:14:35 UTC) #16
commit-bot: I haz the power
4 years, 6 months ago (2016-06-03 03:16:34 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6986d3bf95621f4eb8cd72e0ab823f7b1254fb97
Cr-Commit-Position: refs/heads/master@{#397612}

Powered by Google App Engine
This is Rietveld 408576698