Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 2024993002: Makes RootWindowController window creation in terms of common types (Closed)

Created:
4 years, 6 months ago by sky
Modified:
4 years, 6 months ago
Reviewers:
James Cook
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Makes RootWindowController window creation in terms of common types I plan on moving this code into RootWindowControllerCommon next, but am doing it in two phases to make it easier to see what changed. BUG=none TEST=none R=jamescook@chromium.org Committed: https://crrev.com/e782a261a7dbaa4fc245a8049b35980471c9d84e Cr-Commit-Position: refs/heads/master@{#396915}

Patch Set 1 #

Patch Set 2 : cleanup #

Patch Set 3 : merge 2 trunk #

Unified diffs Side-by-side diffs Delta from patch set Stats (+383 lines, -203 lines) Patch
M ash/root_window_controller.h View 2 chunks +5 lines, -1 line 0 comments Download
M ash/root_window_controller.cc View 1 8 chunks +165 lines, -184 lines 0 comments Download
M ash/shell.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ash/wm/aura/wm_globals_aura.h View 1 chunk +1 line, -0 lines 0 comments Download
M ash/wm/aura/wm_globals_aura.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M ash/wm/aura/wm_window_aura.h View 1 3 chunks +8 lines, -0 lines 0 comments Download
M ash/wm/aura/wm_window_aura.cc View 1 8 chunks +44 lines, -2 lines 0 comments Download
M ash/wm/common/wm_globals.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M ash/wm/common/wm_window.h View 1 5 chunks +36 lines, -0 lines 0 comments Download
M ash/wm/common/wm_window_property.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/common/workspace/workspace_layout_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M mash/wm/bridge/wm_globals_mus.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M mash/wm/bridge/wm_globals_mus.cc View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M mash/wm/bridge/wm_window_mus.h View 1 4 chunks +17 lines, -0 lines 0 comments Download
M mash/wm/bridge/wm_window_mus.cc View 1 2 7 chunks +62 lines, -5 lines 0 comments Download
M mash/wm/non_client_frame_controller.cc View 2 chunks +7 lines, -4 lines 0 comments Download
M mash/wm/root_window_controller.cc View 1 2 1 chunk +17 lines, -3 lines 0 comments Download
M ui/wm/core/visibility_controller.h View 1 1 chunk +2 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 16 (7 generated)
sky
4 years, 6 months ago (2016-05-31 17:28:02 UTC) #1
James Cook
LGTM
4 years, 6 months ago (2016-05-31 18:19:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2024993002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2024993002/20001
4 years, 6 months ago (2016-05-31 18:54:56 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/192285)
4 years, 6 months ago (2016-05-31 19:04:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2024993002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2024993002/20001
4 years, 6 months ago (2016-05-31 19:14:22 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/192300)
4 years, 6 months ago (2016-05-31 19:22:03 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2024993002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2024993002/40001
4 years, 6 months ago (2016-05-31 19:25:47 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-05-31 20:29:12 UTC) #14
commit-bot: I haz the power
4 years, 6 months ago (2016-05-31 20:45:18 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e782a261a7dbaa4fc245a8049b35980471c9d84e
Cr-Commit-Position: refs/heads/master@{#396915}

Powered by Google App Engine
This is Rietveld 408576698