Creates RootWindowControllerCommon

Creates RootWindowControllerCommon

At this point it's only code to create the containers and it isn't
used by mash yet, but it's a good stepping stone.

BUG=none
TEST=none
R=jamescook@chromium.org

Committed: https://crrev.com/ee78dde42fe284e47ca51b1a5ba25b9b880ce43d
Cr-Commit-Position: refs/heads/master@{#397012}

[James Cook, 2016-05-31 18:22:58]

LGTM. Thanks for splitting this into 2 CLs. It was much easier to review.

https://codereview.chromium.org/2027733002/diff/1/ash/root_window_controller_...
File ash/root_window_controller_common.h (right):

https://codereview.chromium.org/2027733002/diff/1/ash/root_window_controller_...
ash/root_window_controller_common.h:19: class ASH_EXPORT
RootWindowControllerCommon {
Does this need to be exported? For tests?

[sky, 2016-05-31 19:26:55]

https://codereview.chromium.org/2027733002/diff/1/ash/root_window_controller_...
File ash/root_window_controller_common.h (right):

https://codereview.chromium.org/2027733002/diff/1/ash/root_window_controller_...
ash/root_window_controller_common.h:19: class ASH_EXPORT
RootWindowControllerCommon {
On 2016/05/31 18:22:58, James Cook wrote:
> Does this need to be exported? For tests?

It doesn't. Removed.

[sky, 2016-05-31 20:30:37]

The CQ bit was checked by sky@chromium.org

[sky, 2016-05-31 20:30:38]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamescook@chromium.org
Link to the patchset: https://codereview.chromium.org/2027733002/#ps20001
(title: "merge and no export")

[commit-bot: I haz the power, 2016-05-31 20:32:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2027733002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2027733002/20001

[commit-bot: I haz the power, 2016-05-31 20:35:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-31 20:35:13]

Try jobs failed on following builders:
  ios-device on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)
  ios-simulator on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[sky, 2016-05-31 20:38:57]

The CQ bit was checked by sky@chromium.org

[sky, 2016-05-31 20:38:58]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamescook@chromium.org
Link to the patchset: https://codereview.chromium.org/2027733002/#ps40001
(title: "merge and not relative")

[commit-bot: I haz the power, 2016-05-31 20:39:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2027733002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2027733002/40001

[commit-bot: I haz the power, 2016-05-31 20:50:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-31 20:50:54]

Try jobs failed on following builders:
  win_clang on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[sky, 2016-05-31 21:20:40]

The CQ bit was checked by sky@chromium.org

[sky, 2016-05-31 21:20:40]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamescook@chromium.org
Link to the patchset: https://codereview.chromium.org/2027733002/#ps60001
(title: "merge")

[commit-bot: I haz the power, 2016-05-31 21:21:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2027733002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2027733002/60001

[commit-bot: I haz the power, 2016-05-31 23:46:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-31 23:46:26]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[sky, 2016-06-01 00:03:00]

The CQ bit was checked by sky@chromium.org

[commit-bot: I haz the power, 2016-06-01 00:03:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2027733002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2027733002/60001

[commit-bot: I haz the power, 2016-06-01 01:21:54]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-06-01 01:24:21]

Description was changed from

==========
Creates RootWindowControllerCommon

At this point it's only code to create the containers and it isn't
used by mash yet, but it's a good stepping stone.

BUG=none
TEST=none
R=jamescook@chromium.org
==========

to

==========
Creates RootWindowControllerCommon

At this point it's only code to create the containers and it isn't
used by mash yet, but it's a good stepping stone.

BUG=none
TEST=none
R=jamescook@chromium.org

Committed: https://crrev.com/ee78dde42fe284e47ca51b1a5ba25b9b880ce43d
Cr-Commit-Position: refs/heads/master@{#397012}
==========

[commit-bot: I haz the power, 2016-06-01 01:24:22]

Patchset 4 (id:??) landed as
https://crrev.com/ee78dde42fe284e47ca51b1a5ba25b9b880ce43d
Cr-Commit-Position: refs/heads/master@{#397012}