Issue 2024873002: Compute non-final static fields without the constant compiler.

Issue 2024873002: Compute non-final static fields without the constant compiler. (Closed)

Created:
4 years, 6 months ago by Johnni Winther

Modified:
4 years, 6 months ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Compute non-final static fields without the constant compiler. Previously the non-final static fields were pulled from the constant compiler. Now, since all fields have a valid [constant] field, these fields are now computed directly from the set of all referenced static fields. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/f1ba23bd15eb94b76714b4d7e0020052f8a26f6c

Created: 4 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+39 lines, -58 lines)			Patch
M	pkg/compiler/lib/src/compile_time_constants.dart	View	5 chunks	+7 lines, -7 lines	0 comments	Download
M	pkg/compiler/lib/src/js_backend/constant_handler_javascript.dart	View	2 chunks	+0 lines, -24 lines	0 comments	Download
M	pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	pkg/compiler/lib/src/js_emitter/program_builder/collector.dart	View	1 chunk	+14 lines, -11 lines	0 comments	Download
M	pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	tests/compiler/dart2js/serialization/model_test.dart	View	5 chunks	+14 lines, -12 lines	0 comments	Download

Total messages: 5 (2 generated)

Johnni Winther

4 years, 6 months ago (2016-06-02 09:33:55 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
f1ba23bd15eb94b76714b4d7e0020052f8a26f6c (presubmit successful).