pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart - Issue 2024873002: Compute non-final static fields without the constant compiler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart

Issue 2024873002: Compute non-final static fields without the constant compiler. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/compiler/lib/src/js_emitter/program_builder/collector.dart ('k') | tests/compiler/dart2js/serialization/model_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart

diff --git a/pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart b/pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart

index b779ef7727ca15bcb2f6c06902304376046c008f..1f81f6d6b20b329441a0bee3040b08a58fda83a1 100644

--- a/pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart

+++ b/pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart

@@ -260,9 +260,9 @@ class ProgramBuilder {

return staticNonFinalFields.map(_buildStaticField).toList(growable: false);

}

- StaticField _buildStaticField(Element element) {

+ StaticField _buildStaticField(FieldElement element) {

JavaScriptConstantCompiler handler = backend.constants;

- ConstantValue initialValue = handler.getInitialValueFor(element);

+ ConstantValue initialValue = handler.getConstantValue(element.constant);

// TODO(zarah): The holder should not be registered during building of

// a static field.

_registry.registerHolder(namer.globalObjectForConstant(initialValue),